Raise the packaging pin so PyInstaller resolves to a current release - #197
Open
OneSixForensics wants to merge 1 commit into
Open
Raise the packaging pin so PyInstaller resolves to a current release#197OneSixForensics wants to merge 1 commit into
OneSixForensics wants to merge 1 commit into
Conversation
requirements.txt pinned packaging==20.1. PyInstaller 6.x requires
packaging>=22.0, so pip cannot take it and backtracks to the newest release
carrying no packaging constraint at all: 4.5.1, from 2021.
pip install -r requirements.txt pyinstaller
packaging 20.1
pyinstaller 4.5.1 <- silent, no error
4.5.1 predates Python 3.14 and does not support the hide_console option that
scripts/pyinstaller/vleappGUI.spec uses, so a build from a clean environment
fails for reasons that point nowhere near this pin.
packaging is not imported anywhere in VLEAPP; the pin predates the current
requirements and nothing here reads it.
24.1 is the value iLEAPP already carries, so this brings the two into line
rather than inventing a version. With the bump, from the same clean resolution:
packaging 24.1
pyinstaller 6.22.2
Verified by dry-run resolution against this repo's own requirements.txt, both
ways, changing nothing but this line.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
requirements.txtpinspackaging==20.1. PyInstaller 6.x requirespackaging>=22.0, so pip cannot take it, backtracks, and lands on the newest release that carries nopackagingconstraint at all — 4.5.1, from 2021:4.5.1 predates Python 3.14 and does not support the
hide_consoleoptionscripts/pyinstaller/vleappGUI.specuses, so a build from a clean environment fails in ways that point nowhere near this pin. You only notice if you happen to check which PyInstaller you actually got.The change
packagingis not imported anywhere in VLEAPP — nothing here reads it.24.1is the value iLEAPP already carries, so this matches an existing core rather than inventing a version. From the same clean resolution:Verified
pip dry-run resolution against this repo's own
requirements.txt, both ways, changing nothing but this line:20.1→ PyInstaller 4.5.1,24.1→ PyInstaller 6.22.2.The same one-line change is going to the other affected cores; it was found while building DLEAPP, where it is #124. iLEAPP is already on
24.1and is unaffected.