Take the shared app-rules check that also runs daily - #838
Merged
Conversation
Synced from abap2UI5/.github/shared/check-app-rules.yaml, which grew a schedule for a gap this repository was on the wrong end of. The app rule set is a SECTION of abaplint.jsonc rather than a file of its own, so sync-shared deliberately does not carry it - copying the source over this file would destroy the rest, which this repository owns. A change to the rule set upstream therefore has to be brought across by hand, and until it is, this repository has drifted. The check only ran on pull_request and push, which are events HERE, while the drift is created by a commit THERE. So with no activity here nothing noticed: abap2UI5 #2739 changed the rule set on 2026-09-12 and this repository was red from that moment without a run to say so. The daily run answers it every morning, and a red scheduled run opens an issue instead of sitting in the Actions tab. Byte-identical to its source, as check:shared requires. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F6kfouTe7NJ2bfEebXB999
Synced from abap2UI5: the tee landed next to the sources, which makes the transcript a file this repository never declared - and every generator and prose walker here enumerates what is in the tree. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01F6kfouTe7NJ2bfEebXB999
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synced from
abap2UI5/.github/shared/check-app-rules.yaml, which grew a schedule for a gap this repository was on the wrong end of.The app rule set is a section of
abaplint.jsoncrather than a file of its own, sosync-shareddeliberately does not carry it — copying the source over this file would destroy the rest, which this repository owns. A change to the rule set upstream therefore has to be brought across by hand, and until it is, this repository has drifted.The check only ran on
pull_requestandpush, which are events here, while the drift is created by a commit there. So with no activity here nothing noticed: abap2UI5 #2739 changed the rule set on 2026-09-12 and this repository was red from that moment without a single run to say so. It was found a day later from the other side.Now it also runs daily (04:17 UTC) and on
workflow_dispatch, and a red scheduled run opens an issue instead of sitting in the Actions tab — best-effort, and never the reason the job is red.Byte-identical to its source, as
check:sharedrequires. Companion to abap2UI5#2744, which holds the source copy.How to test
🤖 Generated with Claude Code
https://claude.ai/code/session_01F6kfouTe7NJ2bfEebXB999
Generated by Claude Code