Follow the promoted samples to src/01, and catch up two generated artefacts - #321
Merged
Merged
Conversation
…5 main Two generated artefacts had fallen behind their sources, both before this branch and both red on main: `check:api-reference` and `check:samples`. `docs/resources/api.md` and `docs/public/api/client-api.json` were missing the `cs_event-store_data` paragraph that `z2ui5_if_client` has carried on abap2UI5 main for a while - `npm run generate:api` reads the interface there, so the block is its output, not a hand edit. `cookbook/model/tables` still called Z2UI5_CL_SMP_APP_059 "Live Search with Parallel Requests"; the sample was retitled "Live Search over a Large Table" in abap2UI5/samples#839 and `npm run link:samples` picks the title out of that repository's catalogue. Neither is this branch's change - they are ported so the pull request can go green on its own failures rather than on somebody else's. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
abap2UI5/samples#843 removed the `src/00/97` package and promoted its fourteen samples into `src/01`. The links published here point at that repository's `main` - `.github/workflows/check.yml` pins the checkout to it on purpose - so every one of them moved the moment that merged, and `check:samples` went red on this repository's `main` through no change of its own. Eight generated sample blocks are regenerated with `npm run link:samples`: their rows now carry `src/01` paths, and the titles lose the `Hash — ` / `Device — ` header prefix, because a promoted sample is a catalogue entry and the block strips the category the way it always has for `src/01` rows. The two links the deprecations page writes BY HAND - the `omit_initial` and `json = abap_true` samples of the AJSON replacement table, `Z2UI5_CL_SMP_APP_507` and `_509` - are not generated and were not caught by the regeneration; they are repointed at `src/01` here. A reader clicking either got a 404 in between. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two generated artefacts had fallen behind their sources and one whole set of links moved out from under this repository. Both are mechanical catch-ups; no page is rewritten.
The sample links moved (
de2b7b1)abap2UI5/samples#843 removed the
src/00/97("experimental") package and promoted its fourteen samples intosrc/01. The links published here point at that repository'smain—.github/workflows/check.ymlpins the checkout to it on purpose, with the comment "the links published here point at main, so main is what they have to be true against" — so every one of those paths moved the moment that merged, andcheck:samplesreports ten problems against currentmain.npm run link:samples. Their rows now carrysrc/01paths, and the titles lose theHash —/Device —header prefix: a promoted sample is a catalogue entry, and the block has always stripped the category forsrc/01rows.resources/deprecations.mdwrites by hand —Z2UI5_CL_SMP_APP_507and_509, theomit_initialandjson = abap_truerows of the AJSON replacement table. No generator touches those, so the regeneration did not catch them; they are repointed atsrc/01here. A reader clicking either got a 404 in the meantime.Two generated artefacts were stale before that (
237c03b)Both were already red on
main, neither caused by this branch:docs/resources/api.mdanddocs/public/api/client-api.jsonwere missing thecs_event-store_dataparagraph thatz2ui5_if_clienthas carried on abap2UI5mainfor a while.npm run generate:apireads the interface there, so the block is its output, not a hand edit.cookbook/model/tablesstill calledZ2UI5_CL_SMP_APP_059"Live Search with Parallel Requests"; the sample was retitled "Live Search over a Large Table" in Refactor sample 059: live search with check_queue_last samples#839.This commit was pushed to the branch of #319 a few minutes after that pull request had already merged, so it did not go in with it. The branch is restarted from
mainand it is carried here.How it was verified
test,check:version,check:conventions,check:examples,check:playground,check:api-names,check:api-reference,check:samples,check:design,check:images— all pass against a samples checkout atmain.check:cross-sitewas not run locally: it reads a built site, anddocs:buildneeds to fetch the playground sitemap, which this sandbox's proxy refuses. It runs in CI.🤖 Generated with Claude Code
https://claude.ai/code/session_019rmo8XKoBEpBRZ2TZMUQrF
Generated by Claude Code