Message: say which half of the API a call belongs to - #316
Merged
Merged
Conversation
abap2UI5 takes the plain sap.m options off client->message_toast_display( ) and client->message_box_display( ): the client method carries what an ABAP app decides - the data in any shape, the kind of box, the buttons as a table, the backend event its closing raises - and a pure UI5 option is set on the control, as the option object of a follow_up_action( cs_event-control_global ) call, which is the sap.m API 1:1. The Message page gets that as a section of its own, with the table of which option moved where and the wired, round-trip-free form; Frontend Actions says next to control_global that a t_arg starting with a brace travels as real JSON, which is what carries those options. Z2UI5_CL_SMP_APP_512 joins the page's sample list as the control-side counterpart of 502. Also repaired: two deprecation-page links into src/00/97, a package that no longer exists in abap2UI5/samples, and the sample-link blocks the generator refreshes with them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CigShdooBBhKDDztTLpsZq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to abap2UI5/abap2UI5#2748, which takes the plain
sap.moptions offclient->message_toast_display( )andclient->message_box_display( ).The Message page gets that split as a section of its own: the client method is the ABAP side — hand it what the app already holds and it works out severity, title and rendering — while a pure UI5 option is set on the control, as the option object of a
follow_up_action( cs_event-control_global )call, which is thesap.m.MessageToast.show( )/sap.m.MessageBox.<type>( )API 1:1. With it: the table of which option moved where, and the wired, round-trip-free form that fills{0}placeholders on the client.Frontend Actions says next to
control_globalthat at_argstarting with a brace travels as real JSON — the mechanism those options ride on — and links back.Z2UI5_CL_SMP_APP_512joins the Message page's sample list as the control-side counterpart of 502.Also repaired, found by the same gate run: two deprecation-page links into
src/00/97, a package that no longer exists in abap2UI5/samples, and the generated sample-link blocks that carry the same stale paths.Checks:
npm run check:examples,check:conventions,check:design,check:images,check:playground,check:samplesandnpm test(251/251) pass. Two failures are there onmaintoo and untouched here:check:api-referenceis stale against the framework'smain(it regenerates once #2748 lands) andnpm run buildcannot reachabap2ui5.github.iofrom this environment.🤖 Generated with Claude Code
https://claude.ai/code/session_01CigShdooBBhKDDztTLpsZq
Generated by Claude Code