Support bigint and UUID pagination identifiers - #782
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 853274ceb3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ```ts | ||
| import z from "zod"; | ||
| import { getTableColumns } from "drizzle-orm"; |
There was a problem hiding this comment.
Use the current Drizzle column helper
With the repository's pinned Drizzle v1 release, getTableColumns was renamed to getColumns; the live cron route already imports and calls getColumns in packages/vitnode/src/api/modules/admin/advanced/cron/routes/get.route.ts. Anyone copying this newly updated basic example will therefore get a missing-export error before reaching the pagination code, so replace both getTableColumns references with getColumns.
Useful? React with 👍 / 👎.
Summary
primaryCursorto use integer, bigint, or UUID columnsVerification
pnpm --filter @vitnode/core test— 6,164 tests passedpnpm --filter @vitnode/core test:types— 315 type tests passed, no type errorspnpm --filter @vitnode/core exec tsc -p tsconfig.json --noEmit