feat(settings): add maxNestingDepth and autoFlattenOnLimit settings round-trip - #1264
feat(settings): add maxNestingDepth and autoFlattenOnLimit settings round-trip#1264easonLiangWorldedtech wants to merge 2 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Part 1/8 of the task-tree series (upstream-ready recomposition). Adds `depth` to HistoryItem and a cycle-safe `backfillTaskDepth()` that propagates parent depth through the delegation tree, so every task knows its nesting level. Depth is surfaced for later use by settings validation, environment details, and history-tree display. Includes the single-open-invariant spec mock for backfillTaskDepth (folded in from the series' CI fix) so this PR passes unit tests standalone.
…ound-trip Part 2/8 of the task-tree series (upstream-ready recomposition). Adds two global settings that control subtask delegation: - `maxNestingDepth` (default 2, range 0-5): how many levels a subtask may nest. A value of 0 disables delegation entirely — every new_task runs inline. - `autoFlattenOnLimit` (default true): when the limit is reached, flatten the subtask into the current conversation instead of opening a new tab; when disabled such requests are rejected so you can continue directly. Full round trip: global-settings schema + defaults, ExtensionState, SettingsView control bound to cachedState with save payload, webviewMessageHandler persistence through ContextProxy, ClineProvider getState/getStateToPostToWebview, runtime consumers using the shared defaults. Includes focused tests for UI binding/save, persistence, and the saved value returned to the webview. Also completes the taskTree translation keys in all 17 non-English locales so check-translations passes standalone (folded in from the series' CI fix).
1d83160 to
fe1aac2
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Closing per the author: this stacked series is being re-verified in a fork sandbox before upstream submission. Will be re-opened as individually reviewed PRs once each branch's CI is confirmed green. |
2 participants
Part 2/8 of the task-tree series (builds on part 1). Adds two global settings: maxNestingDepth (default 2, range 0-5) and autoFlattenOnLimit (default true), with full round trip through schema, ExtensionState, SettingsView cachedState binding, webviewMessageHandler persistence, ClineProvider getState/getStateToPostToWebview, and runtime consumers. Also completes the taskTree translation keys in all 17 non-English locales so check-translations passes standalone.