Repository navigation
DXF of each 2D-cut part's flat face in the build pack - #60
Merged
Merged
Conversation
Reads the part's body details (one Onshape request; one more for tessellated edges only when it has a spline or ellipse) beside its STEP, and the browser draws the largest planar face as an R12 DXF in millimetres. Files sit beside the STEP in 2D_cut/, MANIFEST.txt lists each DXF with size and thickness or its failure, and the Make sheet gains a DXF file column.
[Medium impact] The changes since the previous review appear safe to merge; no new actionable issue was established. SummaryAdds browser-drawn DXF files beside STEP files for thin, flat parts.
All four supplied threads are unnumbered and were manually resolved by Reviews (3) · Last reviewed commit: "Greptile: only thickness-keyed configura..." · Reviewed by Greptile |
…lates; geometry reads after STEP polls Owner rule: a DXF only for a flat part 3 mm thick or less; a thicker one is a 3D print. The classifier reads a stated thickness from the name or configuration, and the export applies the same rule to tagged plates and to the thickness measured from the body details it already reads. A person's choice wins. Greptile: reject a pocket-floor face and blind recesses so the DXF never cuts the wrong shape, and read DXF geometry after STEP starts and polls so a rate limit on it cannot cost a STEP its deadline.
# Conflicts: # CLAUDE.md
Contributor
Author
|
@greptile review |
… are thickness; workbook DXF names say when the export's measurement decides
Contributor
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner requests:
What
Each 2D-cut part 3 mm thick or less now gets a DXF of its flat face in the build pack, next to its STEP file.
Onshape endpoint and cost
sheetMetalFlat,flatPatternAsync, bend lines) are for sheet-metal flat patterns.GET /api/v9/parts/d/{did}/{w|v}/{wvid}/e/{eid}/partid/{pid}/bodydetails?configuration=…&includeGeometricData=true.…/partid/{pid}/tessellatededges.onshapeFetcher, the per-poll budget, and the ledger (body-details,tessellated-edges). There is no translation and no polling.Drawing
packages/shared/src/dxf.tspicks the largest planar face of the part's solid body and draws it as seen from outside the part, in millimetres.$INSUNITS4, on layerCUT./api/exports/{jobId}/files/{i}.body|.edges.Thickness rule
Thickness=3+mm.3D_print/, with the note "flat, 6 mm thick: over 3 mm, so 3D printed". The note appears in the Make panel and in MANIFEST.txt.Files
2D_cut/{stepFileName}.dxfsits beside the STEP.pnpm sample:stepnow includes a DXF in the committed sample ZIP.Tests
Checks run locally: eslint, typecheck, unit tests (310), smoke (11), build.
Not verified live
No Onshape request was made, so these still need a live check:
midPointon arc edges,isOrientedWithFace,area, and face loops that list every face's edges.linkDocumentId.