Repository navigation
Review holds unmatched Buy parts, the drawer moves on after a choice, and bulk types - #59
Merged
Merged
Conversation
… and bulk types Parts to buy with no vendor product now wait in Review (No product), with the products, vendor search, and type changes that fix each; Review's count, the primary action, and next moves count them. The part drawer moves to the next part in the list it came from after a saved choice and says where the part went. Review rows can be selected (shift-click range, whole subassembly) and given one type, saved per part with failures kept selected. Pattern and Replicate copies are already counted (the definition lists them as instances); a fixture pins it.
[Medium impact] The PR appears safe to merge; no actionable issue remains from the reviewed changes. SummaryThis PR puts unmatched Buy parts in Review, advances the drawer after saved choices, and adds bulk type choices.
Reviews (4) · Last reviewed commit: "Greptile: subassembly selection follows ..." · Reviewed by Greptile |
… stays in its Review group
Contributor
Author
|
@greptile review |
Contributor
Author
|
@greptile review |
…-click anchors by part
Contributor
Author
|
@greptile review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner's four requests from the live HORS panel.
1. Unmatched Buy parts are in Review
Buy parts with no exact or confirmed product (
needsProduct) now show up in Review as their own group, No product. Each row offers the fixes it has:choices, andnearMatches.These all count the same number (
Summary.toReview= undecided + unmatched): the Review tab's count and dot, the Overview primary action ("Review N parts"), and its first next move. The separate "unmatched" primary action and next move are gone.The Buy list keeps its "No vendor match yet" group. The Buy list is the whole order, and hiding those parts would understate what has to be bought. The group now gets a Resolve in Review button that opens Review on No product, and Overview's "No vendor yet" row does the same.
applyMatchDecisionnow also accepts a pick on a rejected line, so a part's near matches can still be chosen after you reject its product.2. The drawer moves on after a choice
A part now opens together with its list: Review's filtered order, a Buy list or Make group, or the Parts filter. When a type or product choice saves, the drawer shows the next part still in that list and says "{name} moved to 3D print". When nothing is left, or the part was opened on its own (Overview search), the drawer closes and the same note appears as a toast. A failed save leaves the drawer on the part and shows the error.
The drawer also lists an unmatched part's closest products.
Separately, Enter in Overview's search used to open the drawer and close it again at once, because focus stayed in the field. That is fixed.
3. Bulk types in Review
4. Fastener counts
Onshape's OpenAPI (
BTRootAssemblyInfo,BTSubAssemblyInfo) says the definition'sinstancesinclude "those created by patterns and replicates". Our walk counts every instance, so pattern and Replicate copies were already counted. On the saved HORS scan, BOM quantities matched the definition on all 102 matched rows.fixtures/assembly-patterns.jsonpins this: a circular pattern, Replicate copies, a linear pattern inside a subassembly placed twice, and a suppressed pattern copy. No extra Onshape request is needed. The "can be low" notes in the Buy list, workbook, and classifier now say that copies are counted and only fasteners that were never modelled are missing. This has not been checked against a live assembly that uses Replicate.Screenshots
Fixture mode, saved HORS scan, production catalogs.
Checks