Skip to content

feat(ios): iPhone build and TestFlight upload (iOS phase 1) - #133

Open
thangnm93 wants to merge 39 commits into
developfrom
feature/ios-phase1
Open

thangnm93 wants to merge 39 commits into
developfrom
feature/ios-phase1

Conversation

@thangnm93

Copy link
Copy Markdown
Collaborator

Summary

Runs the mobile app on iPhone and adds a signed TestFlight upload to the release workflow.

  • App: hosts, SSH terminal, SFTP and the Keychain screens work as on Android. Secrets live in the iOS Keychain (this-device-only, no plaintext fallback). Imported keys are copied into Application Support, which is excluded from backup; stale container paths are rebased on load after an iOS update.
  • App lock: covers the whole app and uses Face ID. It also stays hidden on a cold start until the gate has decided (new in this PR).
  • Lifecycle: the connection is kept for a short grace period in the background, then paused (SFTP retry and LAN sync stop too) and resumed on return.
  • Links: yourssh://connect/<host> links work. ssh:// links are an opt-in setting that never connects to an unknown target and waits for unlock.
  • Desktop only: local shell, RDP and VNC; RDP/VNC hosts show a "desktop only" notice.
  • Compliance: PrivacyInfo.xcprivacy, ITSAppUsesNonExemptEncryption = YES, no ATS exceptions.
  • CI (pr-test.yml): a new ios job runs unit tests, simulator and release builds, tool/check_ios_bundle.sh and a simulator smoke test. A changes job (tool/ios_ci_needed.sh) skips it for documentation-only PRs.
  • Release (release.yml): build-ios builds a signed IPA and uploads it to TestFlight, but only when the iOS secrets are set. The IPA is not attached to the GitHub release.
  • SwiftPM: the two iOS Package.resolved files are committed to pin file_picker's DKCamera/DKPhotoGallery.

Spec: docs/superpowers/specs/2026-11-12-yourssh-ios-design.md
Plan: docs/superpowers/plans/2026-11-12-yourssh-ios-phase1.md

Merge notes

feature/ios was merged onto develop 57fad900:

  • CHANGELOG: develop's file plus a new [Unreleased] section with only the iOS entries.
  • KeyProvider: develop's sshDirPath and dismissed-paths list were combined with feature/ios's keysDirPath seam, iOS path rebase and owned-file removal.
  • App lock comment: the stale mobileAppLocked doc comment is updated.

Owner setup before the first TestFlight build

  • An Apple Distribution certificate as a .p12 under team 84T567KMYD.
  • An App Store provisioning profile named YourSSH App Store for com.thangnm.yourssh.
  • An App Store Connect app record for that bundle id.
  • An App Store Connect API key.
  • Repo secrets: IOS_DISTRIBUTION_P12_BASE64, IOS_DISTRIBUTION_P12_PASSWORD, IOS_PROVISIONING_PROFILE_BASE64, ASC_KEY_ID, ASC_ISSUER_ID, ASC_API_KEY_P8_BASE64.

Until these are set, build-ios is skipped and the desktop/Android release is unchanged.

Test plan

  • flutter test on the merged tree: 2909 passed, 16 skipped
  • flutter analyze --no-fatal-infos: no errors or warnings
  • tool/check_ui_lint.sh: OK
  • pr-test ios job green (simulator build, release build, bundle check, smoke test)
  • First TestFlight upload after the secrets are set

https://claude.ai/code/session_01YGAGXFNiYwvqiuiRKg25y2

Baseline passed with no widget changes needed; simulator checks (step 3) remain manual/CI (Task 12).
…import

Keys are copied into Application Support/keys (0700, excluded from backup),
the picker temp copy is cleared, downloads stream through a .part file and
the SFTP screen drops a dead channel and retries once after a resume.
iOS phase 1 (iPhone build, TestFlight upload) onto develop.

Conflict resolutions:
- CHANGELOG.md: develop's file plus a new [Unreleased] section with only
  the iOS entries; the older feature/ios [Unreleased] items already shipped
  in 0.4.0 / 0.4.1.
- KeyProvider: keep develop's sshDirPath and dismissed-paths list and
  feature/ios's keysDirPath seam, iOS path rebase and owned-file removal;
  both test groups kept.
- mobileAppLocked doc comment: the gate now sits in MaterialApp.builder and
  covers every route; the notifier only defers link handling until unlock.
The gate started unlocked and only locked once the app-lock setting and
device support had been read, so a cold start painted the hosts list for
a few frames before the lock screen. Until that decision the child now
stays offstage behind a blank screen (no Unlock button yet).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant