Repository navigation
chore: reproducible docs screenshot journey and updated screenshots skill - #125
Merged
Merged
Conversation
… update screenshots skill
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the docs screenshot journey (
tool/docs_journey.sh) reproducible from the repo alone and points theyourssh-screenshotsskill at it.setup:~/.local/state/yourssh-docs-journey, orDOCS_KEY_DIR).tool/docs_journey/Dockerfile. The Dockerfile contains no keys; the public key is installed withdocker exec.teardown: removes only those containers, the network and the image, by name.DOCS_PREFIXand the port variables let a second set run next to an existing one.run/all: fail with a clear message when the key or a container is missing. The isolation checks are kept: the real prefs plist mtime and the~/.yoursshhash must be unchanged.feature_screenshots_test.dartpath is marked as touching the real prefs.Verified:
setup/teardownran with a separate prefix and separate ports, leaving the existing containers alone.db-internalresolved through the network, and the RDP user exists.https://claude.ai/code/session_01YGAGXFNiYwvqiuiRKg25y2