Skip to content

chore: reproducible docs screenshot journey and updated screenshots skill - #125

Merged
thangnm93 merged 1 commit into
developfrom
chore/docs-journey-skill
Nov 13, 2026
Merged

thangnm93 merged 1 commit into
developfrom
chore/docs-journey-skill

Conversation

@thangnm93

Copy link
Copy Markdown
Collaborator

Makes the docs screenshot journey (tool/docs_journey.sh) reproducible from the repo alone and points the yourssh-screenshots skill at it.

  • Removed a leaked path: the hardcoded demo-key path, which pointed into a local temp folder and included the user name, is gone.
  • setup:
    • Generates a fresh ed25519 client key outside the repo (~/.local/state/yourssh-docs-journey, or DOCS_KEY_DIR).
    • Builds tool/docs_journey/Dockerfile. The Dockerfile contains no keys; the public key is installed with docker exec.
    • Creates the network and the 5 demo containers: ssh, bastion, internal db, RDP, VNC.
    • Re-running reuses existing containers.
  • teardown: removes only those containers, the network and the image, by name.
  • Overrides: DOCS_PREFIX and the port variables let a second set run next to an existing one.
  • run / all: fail with a clear message when the key or a container is missing. The isolation checks are kept: the real prefs plist mtime and the ~/.yourssh hash must be unchanged.
  • Skill: the isolated journey is now the default path. It covers re-running a subset and refreshing README images. The old feature_screenshots_test.dart path is marked as touching the real prefs.

Verified:

  • setup/teardown ran with a separate prefix and separate ports, leaving the existing containers alone.
  • Key-only ssh login worked, db-internal resolved through the network, and the RDP user exists.

https://claude.ai/code/session_01YGAGXFNiYwvqiuiRKg25y2

@thangnm93
thangnm93 merged commit c7b034b into develop Nov 13, 2026
11 checks passed
@thangnm93 thangnm93 mentioned this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant