Skip to content

feat(ui): forui Amber Brand redesign (phases 0-6) + docs-run fixes - #121

Merged
thangnm93 merged 136 commits into
developfrom
feature/ui-shell
Nov 13, 2026
Merged

thangnm93 merged 136 commits into
developfrom
feature/ui-shell

Conversation

@thangnm93

@thangnm93 thangnm93 commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

The forui "Amber Brand" redesign, phases 0–6. This branch contains phase 0 (PR #118) and supersedes it.

  • Design system: packages/yourssh_ui wraps forui and provides tokens (YsColors, YsSpace, YsRadius), the desktop and touch themes, and the components (YsTab, YsDialog/showYsConfirm, showYsToast, YsFileTable, YsHostCard, YsStatusBar, YsPluginHost).
  • Screens moved to forui:
    • Desktop: shell (sidebar, tab bar), hosts dashboard and host editor, terminal, SFTP, port forwarding, keychain, known hosts, recordings, audit log, settings.
    • Plugins: Snippets, DevOps and Web Tools.
    • Mobile.
  • UI lint gate: tool/check_ui_lint.sh runs in CI and fails on Material widgets the migration replaced. The allowlist is empty.
  • Verification:
    • Each task was reviewed, and the whole branch was reviewed on opus.
    • Terminal throughput was measured against v0.3.0 with no regression.
    • A scripted user journey drove the final app against demo containers and captured 209 screenshots for the docs. Its findings and a shot-by-shot review produced 24 fixes, all re-checked on a final run.
  • Notable fixes:
    • Host editor no longer reuses form state across hosts (data loss).
    • Snippets moved out of the native store by the half-migrated bundled JS plugin are recovered. That plugin is no longer shipped, and built-in plugin ids are reserved. This bug is also on master.
    • Fast exec commands no longer lose their exit status (dartssh2).
    • Unresolvable hosts time out with a reason instead of hanging on "Connecting…".
    • RDP fullscreen no longer raises a framework error.
    • Shell-integration gutter markers follow their lines.
    • A new session shows a single prompt.
    • New confirmations before destructive actions.
  • Changelog and docs: CHANGELOG [Unreleased], CLAUDE.md, README screenshots refreshed.

Spec: docs/superpowers/specs/2026-11-12-yourssh-ui-redesign-design.md. Plans: docs/superpowers/plans/2026-11-12-yourssh-ui-redesign-phase0-1.md and …-phase2-6.md. Task docs: .docs/ui-redesign/.

https://claude.ai/code/session_01YGAGXFNiYwvqiuiRKg25y2

All contrast pairs passed; no token adjusted.
Uses package:material_ui (flutter/material.dart is deprecated in 3.50).
# Conflicts:
#	.github/workflows/pr-test.yml
#	CHANGELOG.md
#	app/pubspec.lock
# Conflicts:
#	.github/workflows/pr-test.yml
#	app/lib/main.dart
… empty one above

The shell-integration handshake discards the bootstrap echo, but the prompt
the shell painted before it stayed on screen and the next prompt appeared
on the line below, so every new session started with a blank prompt. On a
clean DONE the gate now clears the cursor's line and drops the sentinel's
line break, so the shell's next prompt takes that row. An oversized head
(real output held) and the timeout flush are left untouched.
Clear all also truncates the catcher log on the host, so it now asks first
(Cancel focused, Clear destructive) like the other destructive actions.
Choosing "Color tag" closes the tab menu before opening the submenu, so the
second Esc reached the shell as ESC and ate the next keystroke (Meta-e).
@thangnm93 thangnm93 changed the title feat(ui): redesign phases 1-3 — shell, hosts, terminal (WIP) feat(ui): forui Amber Brand redesign (phases 0-6) + docs-run fixes Nov 13, 2026
@thangnm93
thangnm93 marked this pull request as ready for review November 13, 2026 07:06
@thangnm93
thangnm93 merged commit 8c6f0cd into develop Nov 13, 2026
11 checks passed
@thangnm93 thangnm93 mentioned this pull request Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant