Repository navigation
feat(group-preservation): add toggle to protect existing groups and add autostack caution tooltip - #2
Merged
Merged
Conversation
…dd autostack caution tooltip
Resolve conflicts with session snapshots: bump version to 1.4.0 (master shipped 1.3.0) and register the preserve-groups toggle alongside the snapshot settings in the options auto-save list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
With Preserve Existing Groups on, the grouper skipped every grouped tab, including stacks TabStack made itself. A new same-site tab then stayed loose (below minTabsToGroup) or formed a duplicate stack, and tab counts in titles went stale. Treat a group as TabStack's when its title is the stack name for one of its tabs' domains (with an optional " (n)" count). Titles survive browser restarts, and groups the user creates or renames still never match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves an issue where automatic domain clustering reorganized existing or custom user groups (for example, consolidating separate YouTube groups like Group 1 with 2 tabs and Group 3 with 4 tabs into a single generic stack).
It introduces a Preserve Existing Groups toggle directly accessible and clearly explained on the extension dashboard and options page, and adds a caution indicator
(i)alongside the Auto-Stack toggle to forewarn users about real-time background reorganization.Key Changes
Preserve Existing Groups Toggle (
preserveExistingGroups):preserveExistingGroups: truedefault setting inDEFAULT_SETTINGS.groupTabsInWindowignores any tab with an existing group ID (tab.groupId > 0). It strictly clusters ungrouped tabs, ensuring custom groups, manual titles, and distinct same-domain groupings remain completely intact.Dashboard UI & Clear Descriptions:
popup.htmldirectly under the quick toggles with a shield icon, live status badge (Protected/Off), and an explicit description:"Only clusters ungrouped tabs. Existing or custom groups are protected and will never be modified or merged."
options.htmland wired auto-save inoptions.js.Auto-Stack Caution Tooltip
(i):(i)adjacent to the Auto-Stack toggle in both the popup dashboard and options page."Caution: When Auto-Stack is enabled, TabStack automatically reorganizes and groups tabs in real time as you browse or open new tabs."
Version Bump:
versionfrom1.1.0to1.2.0inmanifest.jsonper repository guidelines.Verification Checklist
grouper.js,constants.js,popup.js,options.js).