Repository navigation
Stabilize WebKit spacing acceptance during route entry - #10
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pages deployment after the Today card fix was blocked by an intermittent WebKit browser test. During the Settings route entrance animation, WebKit can report no active animation before its first paint; the spacing test then samples the 18 px translated entry frame as horizontal overflow.
Poll for the settled layout before asserting no overflow. This preserves the narrow-screen layout check while avoiding the transient route frame.
Validation: focused WebKit spacing test passed four times locally, including three consecutive repeat runs. The prior merged run passed 54 of 55 browser tests; this is the sole failing assertion.