Repository navigation
Fix ink, lasso, crop and text box walk bugs - #206
Merged
Merged
Conversation
On a thin selection (one line of handwriting) the rewrap handle, centered on the right edge, lay exactly over the bottom right resize handle, so a resize drag started handwriting recognition. Move it clear of the corner handles, past the right edge. Bug id A2-A09-5. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
New text box used the view corner with no check for the page title or other blocks, so it covered the title and took its clicks (A1-A07-5). It also added a box on a page locked for reading (A2-A08-2). The free-space search that pictures and attachments use now lives in layout/freeSpot and the text box uses it; the lock blocks the new box and a tap on empty page. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The crop window clipped everything inside it, so each handle, centered on the window edge, lost the half of its hit area outside the window and its center sat on the clip edge. A mouse or pen press there reached the world layer and moved the image instead of cropping. Clip only the bright picture, in its own wrapper. Bug id A1-A07-2. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The page's one-finger pan (priority 50) always claimed a touch before the objects tool (priority 30), so a finger drag on an image panned the page and never moved the image, while a mouse or pen moved it. A finger press on the drag body of a block that is already selected now goes to the objects tool; on any other block or empty page it still pans, and a tap selects. Bug id A1-A07-11. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Placing the text box clear of the title grew createPageLayout past the 100 line error limit. Move the point calculation to a function and the new tests to their own group. No behavior change (A1-A07-5). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Newer Cargo puts test exes under build/<crate>/<hash>/out, so the fixed two-level walk missed examples/fake_app.exe. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walk fixes for ink, lasso, layers and page objects (part 1 of 2).
Fixed:
Not fixed: A1-A01-7. It does not reproduce on beta, because attachFiles already uses defaultPlacement.
Tests added (each failed before the fix): selectionFrame thin-selection handle hit test; layout text box under the title and no box while locked; images crop handles hit test; gestures finger drag on a selected image.
🤖 Generated with Claude Code