docs(expandable): Expand accessibility guidance for AI codegen - #4174
williamjstanton wants to merge 3 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe Expandable story reorganizes examples and replaces narrative accessibility guidance with structured sections covering built-in behavior, composition requirements, and anti-patterns. ChangesExpandable documentation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The accessibility documentation update is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
william-aidocs-expandable
|
| Run status |
|
| Run duration | 02m 37s |
| Commit |
|
| Committer | William Stanton |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
17
|
|
|
0
|
|
|
830
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
19.8%
|
|
|---|---|
|
|
1537
|
|
|
377
|
Accessibility
99.06%
|
|
|---|---|
|
|
5 critical
5 serious
3 moderate
2 minor
|
|
|
76
|
Summary
Expands Expandable Storybook docs so AI codegen (and humans) can compose an accessible disclosure or accordion without duplicating built-in ARIA.
The Accessibility section now matches the Dialog / FormField / Checkbox pattern: minimum structure aligned to Basic Example, built-in
aria-expanded/aria-controls/display: nonebehavior, a three-way composition choice (single disclosure, accordion via Hoisted Model, navigation list), heading-level prompts, a requirements table, and anti-patterns. Usage no longer restates those a11y rules; the first example is titled Basic Example.Release Category
Documentation
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
modules/react/expandable/stories/Expandable.mdx— Accessibility, then Usage (Basic Example, Avatar, Hoisted Model).Areas for Feedback? (optional)
Testing Manually
yarn startand open Components / Containers / Expandable.Screenshots or GIFs (if applicable)
N/A — documentation only. No component API or visual change.
Summary by CodeRabbit