Promotion Nomination App - #7
abhi-matti wants to merge 17 commits into
Conversation
The README provides an overview of the Promotion Nomination App, detailing its features, workflow, and optional enhancements.
Example auditAudited 4 to fix and 10 suggestion(s). Fix before merge
Suggestions (10, never block)
Run it yourself: ACTION items fail the Audit examples check. ADVICE never blocks. Maintainers can add the 7 finding(s) are file-level and appear only in this summary. |
|
Hey @abhi-matti thanks for submitting this PR are you able to accept the changes from the audit? We'd love to get this example in |
Updated managerNomination.pmd to include failOnStatusCodes for endpoints, modified query syntax, and adjusted outbound data structure.
Added optional enhancements and deployment instructions.
| "failOnStatusCodes": [{"code": 400}, {"code": 403}] | ||
| }, | ||
| { | ||
| "_comment": "Retrieves selected worker information", |
There was a problem hiding this comment.
PMDSectionOrderingRule (ADVICE)
PMD sections are not in the correct order.
Expected: [1. id, 2. securityDomains, 3. endPoints, 4. outboundData, 5. presentation, 6. _comment, 7. deferred, 8. name, 9. baseUrlType, 10. authType, 11. url, 12. failOnStatusCodes]
Actual: [1. id, 2. securityDomains, 3. endPoints, 4. _comment, 5. deferred, 6. name, 7. baseUrlType, 8. authType, 9. url, 10. failOnStatusCodes, 11. outboundData, 12. presentation]
Why: Ensures PMD file root-level sections follow consistent ordering for better readability
Updated the README to improve clarity and structure, including sections on usage and key capabilities.
What this PR adds or changes
Checklist for new or changed examples
examples/node scripts/validate-examples.mjs --checkpasses (validexample.json, README present, index table in sync)Anything reviewers should know?