Skip to content

I18N: Place translator comments directly before their strings. - #16069

Open
swissspidy wants to merge 2 commits into
WordPress:trunkfrom
swissspidy:fix/translator-comment-placement
Open

swissspidy wants to merge 2 commits into
WordPress:trunkfrom
swissspidy:fix/translator-comment-placement

Conversation

@swissspidy

Copy link
Copy Markdown
Member

Some translator comments were placed in front of a ternary operator or shared a line with several translatable strings. String extraction tools either miss such comments or attach them to the wrong string.

This moves each comment directly before the gettext call it describes:

  • WP_Object_Cache::is_valid_key(): the comment sat before the : of a ternary.
  • WP_Taxonomy::get_default_labels(): one comment was meant for two "Most Used" strings on the same line.
  • WP_Theme_JSON: the comments for "%sX-Small" and "%sX-Large" were attached to "Small" and "Large" instead.
  • update_nag() and wp_notify_postauthor(): the comment was also attached to a second, unrelated string on the same line.

Trac ticket: TODO

Use of AI Tools

Claude-Session: https://claude.ai/code/session_01UWTd5qmztfFv37ybV4xsjV


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 12:02
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props swissspidy, mukesh27.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@mukeshpanchal27 mukeshpanchal27 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the translator-comment placement changes.

No open issues 🎉

Review effort: Balanced

Some translator comments were placed in front of a ternary operator
or shared a line with several translatable strings. String extraction
tools either miss such comments or attach them to the wrong string.

This moves each comment directly before the gettext call it describes:

* `WP_Object_Cache::is_valid_key()`: the comment sat before the `:` of
  a ternary.
* `WP_Taxonomy::get_default_labels()`: one comment was meant for two
  "Most Used" strings on the same line.
* `WP_Theme_JSON`: the comments for "%sX-Small" and "%sX-Large" were
  attached to "Small" and "Large" instead.
* `update_right_now_message()` and `wp_notify_postauthor()`: the
  comment was also attached to a second, unrelated string on the same
  line.
…ed code.

In `wp_dashboard_plugins_output()` the comment for "Install %s" was
also attached to the unrelated "Install" string on the same line.
@swissspidy
swissspidy force-pushed the fix/translator-comment-placement branch from e11f8cf to af77d56 Compare November 18, 2026 14:04
@github-actions

Copy link
Copy Markdown

Trac Ticket Missing

This pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac.

To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants