Repository navigation
I18N: Place translator comments directly before their strings. - #16069
swissspidy wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Some translator comments were placed in front of a ternary operator or shared a line with several translatable strings. String extraction tools either miss such comments or attach them to the wrong string. This moves each comment directly before the gettext call it describes: * `WP_Object_Cache::is_valid_key()`: the comment sat before the `:` of a ternary. * `WP_Taxonomy::get_default_labels()`: one comment was meant for two "Most Used" strings on the same line. * `WP_Theme_JSON`: the comments for "%sX-Small" and "%sX-Large" were attached to "Small" and "Large" instead. * `update_right_now_message()` and `wp_notify_postauthor()`: the comment was also attached to a second, unrelated string on the same line.
…ed code. In `wp_dashboard_plugins_output()` the comment for "Install %s" was also attached to the unrelated "Install" string on the same line.
e11f8cf to
af77d56
Compare
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Some translator comments were placed in front of a ternary operator or shared a line with several translatable strings. String extraction tools either miss such comments or attach them to the wrong string.
This moves each comment directly before the gettext call it describes:
WP_Object_Cache::is_valid_key(): the comment sat before the:of a ternary.WP_Taxonomy::get_default_labels(): one comment was meant for two "Most Used" strings on the same line.WP_Theme_JSON: the comments for "%sX-Small" and "%sX-Large" were attached to "Small" and "Large" instead.update_nag()andwp_notify_postauthor(): the comment was also attached to a second, unrelated string on the same line.Trac ticket: TODO
Use of AI Tools
Claude-Session: https://claude.ai/code/session_01UWTd5qmztfFv37ybV4xsjV
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.