Skip to content

Build/Test Tools: Update Sass to 1.108.2. - #16041

Closed
desrosj wants to merge 1 commit into
WordPress:trunkfrom
desrosj:update/sass-1.108.2
Closed

desrosj wants to merge 1 commit into
WordPress:trunkfrom
desrosj:update/sass-1.108.2

Conversation

@desrosj

@desrosj desrosj commented Nov 16, 2026

Copy link
Copy Markdown
Member

Updates sass from 1.101.0 to 1.108.2. Core only uses it to compile the admin color schemes.

Since Sass 1.101.4, colors with a non-integer channel are written as percentages, which older browsers support, instead of decimal channel values:

- color: rgb(0, 149.5, 221);
+ color: rgb(0%, 58.6274509804%, 86.6666666667%);
  • In the npm run build output, only the 32 color scheme files differ from WordPress/WordPress@c7415c7 (r65534).
  • Only rgb() values change. All 652 are the same colors, to within rounding error.
  • The minified color schemes grow by 1,783 bytes in total.

Trac ticket: https://core.trac.wordpress.org/ticket/65857

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Reviewing the upstream changes, applying the update, comparing the build output with WordPress/WordPress, and drafting the commit message and this description. I reviewed the changes.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Update `sass` from `1.101.0` to `1.108.2`.

Since Sass 1.101.4, colors with a non-integer channel are output using percentages, which older browsers support, rather than decimal channel values. This changes how 652 colors are written in the compiled admin color scheme stylesheets, but not the colors themselves.

See #65857.
@desrosj
desrosj force-pushed the update/sass-1.108.2 branch from 926d448 to 5d3f067 Compare November 17, 2026 14:47
wporg-sync pushed a commit that referenced this pull request Nov 17, 2026
This updates `sass` from `1.101.0` to `1.108.2`. Core only uses Sass to compile the admin color schemes.

Since Sass 1.101.4, colors with a non-integer channel are output using percentages, which older browsers support, instead of
decimal channel values. For example, `rgb(0, 149.5, 221)` is now output as `rgb(0%, 58.6274509804%, 86.6666666667%)`.

Only the 32 compiled color scheme stylesheets change. Every one of the 652 affected `rgb()` values is the same color as before
to within rounding error, and the minified color schemes grow by 1,783 bytes in total. The stylesheets are slightly larger as
a result, but these colors are now valid in a wider range of browsers, including older ones that would otherwise ignore
declarations with decimal channel values.

Developed in: #16041.

See #65857.


git-svn-id: https://develop.svn.wordpress.org/trunk@65555 602fd350-edb4-49c9-b593-d223f7449a82
@desrosj

desrosj commented Nov 17, 2026

Copy link
Copy Markdown
Member Author

Merged in r65555.

@desrosj desrosj closed this Nov 17, 2026
@desrosj
desrosj deleted the update/sass-1.108.2 branch November 17, 2026 15:00
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Nov 17, 2026
This updates `sass` from `1.101.0` to `1.108.2`. Core only uses Sass to compile the admin color schemes.

Since Sass 1.101.4, colors with a non-integer channel are output using percentages, which older browsers support, instead of
decimal channel values. For example, `rgb(0, 149.5, 221)` is now output as `rgb(0%, 58.6274509804%, 86.6666666667%)`.

Only the 32 compiled color scheme stylesheets change. Every one of the 652 affected `rgb()` values is the same color as before
to within rounding error, and the minified color schemes grow by 1,783 bytes in total. The stylesheets are slightly larger as
a result, but these colors are now valid in a wider range of browsers, including older ones that would otherwise ignore
declarations with decimal channel values.

Developed in: WordPress/wordpress-develop#16041.

See #65857.

Built from https://develop.svn.wordpress.org/trunk@65555


git-svn-id: http://core.svn.wordpress.org/trunk@64628 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant