Skip to content

Avoid corrupting options when All Settings exceeds max_input_vars - #11993

Open
Sukhendu2002 wants to merge 2 commits into
WordPress:trunkfrom
Sukhendu2002:fix/25939-all-settings-max-input-vars
Open

Sukhendu2002 wants to merge 2 commits into
WordPress:trunkfrom
Sukhendu2002:fix/25939-all-settings-max-input-vars

Conversation

@Sukhendu2002

@Sukhendu2002 Sukhendu2002 commented May 28, 2026 •

Copy link
Copy Markdown

The All Settings screen submits every editable option, which can exceed PHP's max_input_vars limit. When submitted values are missing, the update handler can overwrite options with null.

This PR updates wp-admin/options.php to:

  • Submit only fields edited on the All Settings screen when JavaScript is enabled.
  • Skip options absent from an All Settings submission rather than updating them to null.
  • Stop processing before any updates when the POST variable count reaches or exceeds a positive max_input_vars limit, with an error explaining how to proceed.
  • Exclude _transient_ and _site_transient_ options from the screen.

The screen remains editable. The handling of missing fields on other settings pages is preserved.

Trac ticket: https://core.trac.wordpress.org/ticket/25939

Use of AI Tools

AI assistance: Yes
Tool(s): Codex through T3 Code
Model(s): gpt-6.1-sol
Used for: Drafting this PR description.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Sukhendu2002
Sukhendu2002 marked this pull request as ready for review May 28, 2026 07:03
@github-actions

github-actions Bot commented May 28, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant