Repository navigation
Avoid corrupting options when All Settings exceeds max_input_vars - #11993
Sukhendu2002 wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
The All Settings screen submits every editable option, which can exceed PHP's
max_input_varslimit. When submitted values are missing, the update handler can overwrite options withnull.This PR updates
wp-admin/options.phpto:null.max_input_varslimit, with an error explaining how to proceed._transient_and_site_transient_options from the screen.The screen remains editable. The handling of missing fields on other settings pages is preserved.
Trac ticket: https://core.trac.wordpress.org/ticket/25939
Use of AI Tools
AI assistance: Yes
Tool(s): Codex through T3 Code
Model(s): gpt-6.1-sol
Used for: Drafting this PR description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.