Skip to content

Improve WP_Term sanitization calls - #11922

Open
Sukhendu2002 wants to merge 6 commits into
WordPress:trunkfrom
Sukhendu2002:ticket-50568-wp-term-sanitization-bypass
Open

Sukhendu2002 wants to merge 6 commits into
WordPress:trunkfrom
Sukhendu2002:ticket-50568-wp-term-sanitization-bypass

Conversation

@Sukhendu2002

@Sukhendu2002 Sukhendu2002 commented May 21, 2026 •

Copy link
Copy Markdown

Avoid redundant term sanitization by bringing WP_Term::filter() closer to the behavior of WP_Post::filter().

This PR:

  • Returns the same WP_Term instance when its filter context already matches the requested context.
  • Retrieves a raw term instance when switching back to raw, using the taxonomy to disambiguate shared terms.
  • Updates get_term() to use the instance returned by WP_Term::filter().
  • Skips repeated sanitize_term() calls for matching non-raw contexts while preserving raw integer normalization.
  • Normalizes cached terms with an empty filter context and updates their cache entries.

Trac ticket: https://core.trac.wordpress.org/ticket/50568

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): gpt-6.1-sol
Used for: Code review and drafting the PR description.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Sukhendu2002
Sukhendu2002 marked this pull request as ready for review May 21, 2026 12:26
@github-actions

github-actions Bot commented May 21, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub or WordPress.org user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

…rm-sanitization-bypass

# Conflicts:
#	tests/phpunit/tests/term/wpTerm.php
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant