Repository navigation
fix(backend): allow orphaned intake recovery (WI-2142) - #497
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related: #438
Current portal deletion already removes linked intakes. This change repairs the remaining recovery path for orphaned legacy records; it does not change normal deletion, routing, mailbox processing, or configuration requirements.
Regression coverage
Companion tests are on core-tests-internal branch
fix/wi-2142-orphaned-intakes. Before the fix, all six admin/delegated-manager recovery cases failed with the reported 400 response. Coverage asserts repaired routing/deletion, exact permission denials with unchanged state, live-portal authorization, invalid replacement targets, and cross-mailbox ownership. Setup uses the production API except for one explicitly documented dangling-reference fixture that current deletion intentionally cannot create.Validation
Passed:
Whole-repository Go lint, SQL/audit/handler-DB/layering/deprecated-API pre-commit guards, and diff checks also passed. Existing ignored frontend build artifacts were copied into the worktree for Go embed. Full application, frontend and browser suites were not run; no frontend source changes.