Repository navigation
fix(email): preserve inbound body formatting (WI-2129) - #495
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related: WI-2129; #484. No issue comments were posted.
Tests
Regression tests live in the companion core-tests-internal branch
fix/wi-2129-email-markdown. The initial persisted-description and persisted-reply tests failed on the old implementation because emphasis/list formatting was lost; both pass with the fix. Fixtures are synthetic reproductions of the formatting loss, not the original reporter MIME message.Passed:
../core-tests/overlay.sh . -- -tags=test -count=1 ./internal/email/... ./internal/emailutil/... ./internal/sanitize/...../core-tests/overlay.sh . -- -tags=test -race -count=1 ./internal/email/... ./internal/emailutil/... ./internal/sanitize/...scripts/run-golangci-lint.sh run --timeout=5m ./internal/email/...go mod tidy -diffandgit diff --check.The first race command exceeded the shell execution limit; the completed race runs passed without changing Go test timeouts. Existing ignored frontend build artifacts were copied into the worktree to satisfy Go embed during whole-repository lint. Full application, PostgreSQL, frontend and browser suites were not run. No frontend source changes or mailbox/plugin changes.