Skip to content

fix(frontend): reliable dependency arrows & correct task preview clicks on Roadmaps #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefan-ernst merged 2 commits into from
Nov 12, 2026
Merged

fix(frontend): reliable dependency arrows & correct task preview clicks on Roadmaps #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07170fb
fix(roadmap): open task preview items correctly
mrtfn Nov 11, 2026
f3c346b
fix(roadmap): render dependency arrows reliably
mrtfn Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 24 additions & 18 deletions frontend/src/lib/features/collections/CollectionRoadmap.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,8 @@
const source = itemMap.get(link.source_id);
const target = itemMap.get(link.target_id);
if (source && target) {
arrows.push({ source, target });
// "Depends On" links run from the dependent (source) to its blocker (target).
arrows.push({ blocker: target, dependent: source });
}
}
}
Expand Down Expand Up @@ -648,9 +649,10 @@

// Sync collection name and load links when items change
$effect(() => {
const dependencyLinkTypeId = roadmapConfig.dependency_link_type_id;
if (!collectionStore.loading) {
currentCollectionName = collectionStore.collectionName;
untrack(() => loadLinksForItems(allItemsSorted));
if (dependencyLinkTypeId) untrack(() => loadLinksForItems(allItemsSorted));
}
});

Expand Down Expand Up @@ -914,15 +916,20 @@
return { startOffset: 0, endOffset: 0 };
}

// SVG arrow path between two items (using treeData indices)
function getArrowPath(source, target, sourceIndex, targetIndex) {
const x1 = (source.barEnd + gridOffset) * colWidth;
const y1 = sourceIndex * ROW_HEIGHT + ROW_HEIGHT / 2;
const x2 = (target.barStart + gridOffset) * colWidth;
const y2 = targetIndex * ROW_HEIGHT + ROW_HEIGHT / 2;

// Connect the facing bar ends, with direction from blocker to dependent.
function getArrowGeometry(blocker, dependent, blockerIndex, dependentIndex) {
const forward = blocker.barStart + blocker.barEnd <= dependent.barStart + dependent.barEnd;
const x1 = ((forward ? blocker.barEnd : blocker.barStart) + gridOffset) * colWidth;
const y1 = blockerIndex * ROW_HEIGHT + ROW_HEIGHT / 2;
const x2 = ((forward ? dependent.barStart : dependent.barEnd) + gridOffset) * colWidth;
const y2 = dependentIndex * ROW_HEIGHT + ROW_HEIGHT / 2;
const midX = (x1 + x2) / 2;
return `M ${x1} ${y1} C ${midX} ${y1}, ${midX} ${y2}, ${x2} ${y2}`;
return {
path: `M ${x1} ${y1} C ${midX} ${y1}, ${midX} ${y2}, ${x2} ${y2}`,
head: forward
? `${x2},${y2} ${x2 - 6},${y2 - 4} ${x2 - 6},${y2 + 4}`
: `${x2},${y2} ${x2 + 6},${y2 - 4} ${x2 + 6},${y2 + 4}`,
};
}

// --- Panel resize handlers ---
Expand Down Expand Up @@ -1505,7 +1512,7 @@
{@const visibleColor = getVisibleColor(roadmapItem.statusColor)}

{#if roadmapItem.isMilestone && !roadmapConfig.end_field_id}
<!-- Diamond milestone (no end field configured, can't expand) -->
<!-- Diamond milestone when no end field is configured -->
<RoadmapItemPreview
item={roadmapItem}
workspace={workspace}
Expand Down Expand Up @@ -1621,21 +1628,20 @@
style="left: 0; top: 0; width: {totalWidth}px; height: {treeData.length * ROW_HEIGHT}px; z-index: 20;"
>
{#each dependencyArrows as arrow}
{@const sourceIdx = treeData.findIndex(i => i.id === arrow.source.id)}
{@const targetIdx = treeData.findIndex(i => i.id === arrow.target.id)}
{#if sourceIdx !== -1 && targetIdx !== -1}
{@const blockerIdx = treeData.findIndex(i => i.id === arrow.blocker.id)}
{@const dependentIdx = treeData.findIndex(i => i.id === arrow.dependent.id)}
{@const geometry = getArrowGeometry(arrow.blocker, arrow.dependent, blockerIdx, dependentIdx)}
{#if blockerIdx !== -1 && dependentIdx !== -1}
<path
d={getArrowPath(arrow.source, arrow.target, sourceIdx, targetIdx)}
d={geometry.path}
fill="none"
stroke="var(--ds-text-subtle)"
stroke-width="1.5"
stroke-dasharray="4,3"
opacity="0.6"
/>
{@const tx = (arrow.target.barStart + gridOffset) * colWidth}
{@const ty = targetIdx * ROW_HEIGHT + ROW_HEIGHT / 2}
<polygon
points="{tx},{ty} {tx - 6},{ty - 4} {tx - 6},{ty + 4}"
points={geometry.head}
fill="var(--ds-text-subtle)"
opacity="0.6"
/>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/lib/features/collections/RoadmapItemPreview.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
portal: 'body',
});

function openItem(event) {
event.stopPropagation();
function openItem(itemId, event) {
event?.stopPropagation();
$open = false;
onopen?.(item.id);
onopen?.(itemId);
}
</script>

Expand Down
Loading