Repository navigation
test(scm): cover GitHub merged_at detection in listed PRs - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds regression coverage for Windshiftapp/core#304.
githubPullRequest.toPullRequest()must treat a non-nilmerged_atas merged, because GitHub's list endpoint (GET /repos/{owner}/{repo}/pulls) omits themergedfield. Without that, SCM sync stores merged PRs as closed and never emitsscm_pr_mergedor runs smart commits.The test drives
ListPullRequeststhrough anhttptestserver with list-shaped JSON (nomergedkey) and covers a merged PR, a closed-unmerged PR, and an open PR, plus the single-PRmerged: truepath.Depends on Windshiftapp/core#309 for the production fix.
internal/scmis not in the fast lane, so this test runs only in the complete Go suite (./test go), which the nightly core-main compatibility lane exercises; the PR unit job runs the fast lane only.Commands run:
./test --core <core-with-fix> go -run 'TestGitHubListPullRequestsDetectsMergedFromMergedAt|TestGitHubPullRequestMergedFlagStillHonoured' ./internal/scm./test --core <core-with-fix> go ./internal/scmbun run scripts/check-public-suite.mjs