Repository navigation
test: sync the public suite with the internal testing repo - #10
Merged
Merged
Conversation
Bring the public core-tests suite up to date with the internal repo and with core main (0ebcef99): - Sync the Go, frontend, and browser tests, including the Plane importer tests and the plugin asset-auth, transition-screen, and collection coverage. - Drop tests for removed features (logbook, llm_proxy, the client-IP rate limiter) and add internal/planeimport to the fast manifest. - Keep the public no-sleep policy: replace time.Sleep and real timers with the ticker and fake-timer patterns the public suite already uses. - Pin the Playwright jobs to ubuntu-24.04; ubuntu-latest now resolves to 26.04, which Playwright 1.59.1 does not support. - Update the migration-catalog expectation for the Plane mapping migration and pin core.ref to the merge that routes imported comments through CommentService. Verified against core 0ebcef99: ./test policy, the full frontend suite (464 files, 3485 tests), and ./test go (all packages) pass.
Refresh stable-selector-exceptions.json for the synced browser specs: preserve the existing review reasons and update the violation counts and fingerprints, and add entries for the newly synced specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bring the public core-tests suite up to date with the internal testing repo and with core
main(0ebcef99). The public suite was last synced on 2026-10-29 (core.ref 240a7d59) and had drifted from both.llm_proxy, and the client-IP rate limiter no longer exist in core.time.Sleepand realsetTimeoutusages were replaced with the ticker and fake-timer patterns the public suite already used (internal/**,tests/**,e2e/tests/auth-lifecycles.spec.ts).internal/planeimportadded to the fast manifest so the importer tests actually run in thequicklane.ubuntu-24.04:ubuntu-latestnow resolves to 26.04, which Playwright 1.59.1 cannot install Chromium on. This is what had been failing the scheduled compatibility job since 2026-10-19.20261122_plane_import_mappings.core.refpinned to0ebcef99, the merge that routes imported Plane comments throughCommentService(fix: write imported Plane comments through CommentService core#486).Verification
Against core
0ebcef99:./test policy— pass../test frontend— 464 files, 3485 tests pass../test go— every Go package passes../test go -run TestNoDirectCommentTableWrites ./internal/services/— pass.Related