Repository navigation
[Fuzzing] Use random.randbytes in fuzz_opt.py - #9332
Merged
Merged
Conversation
make_random_input() previously generated random bytes using a Python list comprehension calling random.randint(0, 255) up to 200,000 times per input file (~18.5ms average per call). Replace this loop with random.randbytes(input_size) (~0.3ms average per call, ~50x faster). Steady-state throughput increases by +7.8% (3.08 -> 3.32 iters/s) for a single worker and +7.4% (81.78 -> 87.85 iters/s) across 32 parallel workers.
tlively
requested review from
stevenfontanella
and removed request for
a team
October 31, 2026 03:10
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the make_random_input function in scripts/fuzz_opt.py to use random.randbytes instead of a list comprehension with random.randint, which simplifies the code and improves performance. There are no review comments to address, and I have no further feedback to provide.
stevenfontanella
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make_random_input() previously generated random bytes using a Python list comprehension calling random.randint(0, 255) up to 200,000 times per input file (~18.5ms average per call). Replace this loop with random.randbytes(input_size) (~0.3ms average per call, ~50x faster).
Steady-state throughput increases by +7.8% (3.08 -> 3.32 iters/s) for a single worker and +7.4% (81.78 -> 87.85 iters/s) across 32 parallel workers.