-
Notifications
You must be signed in to change notification settings - Fork 1
Implement SIP #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DPnimo11
wants to merge
26
commits into
main
Choose a base branch
from
darren-contact-sip
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement SIP #321
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
a16c0c8
feat: add contact estimation and weighting
DPnimo11 d6963d5
feat: add social interaction potential metric
DPnimo11 7cc6173
test: add basic contact/sip sanity tests
DPnimo11 e1c341c
docs: add comments to SIP and contact estimation
DPnimo11 e015c55
refactor: simplify contact sip mvp
DPnimo11 b13011e
docs: add demo contact SIP notebook
DPnimo11 ef4a232
test: add coverage for contact SIP edge cases
DPnimo11 72043fd
test: coverage for empty/missing inputs
DPnimo11 61b278e
test: invalid/empty inputs for contact estimation
DPnimo11 7367699
refactor: tidy up code for style compliance
DPnimo11 98ed7ec
refactor: avoid expensive copy of stop table
DPnimo11 a41597a
perf: add temporal blocking for radius contacts
DPnimo11 0eb392b
Merge branch 'main' into darren-contact-sip
paco-barreras c62e6c3
refactor: bloat removal
DPnimo11 f561428
Merge branch 'darren-contact-sip' of github.com:Watts-Lab/nomad into …
DPnimo11 a976dfe
Merge branch 'main' into darren-contact-sip
paco-barreras 818abc8
refactor: remove redundant helper
DPnimo11 c51511e
Merge branch 'darren-contact-sip' of github.com:Watts-Lab/nomad into …
DPnimo11 3be520d
Update SICSS tutorials
paco-barreras e95c75a
Add Google Timeline section to SICSS tutorial
paco-barreras 7029445
Restore SICSS tutorial download imports
paco-barreras 0bb3d91
refactor: remove useless guards/variables and duplicated work
DPnimo11 5d525ab
Merge branch 'darren-contact-sip' of github.com:Watts-Lab/nomad into …
DPnimo11 ce0c48e
Fix SICSS Part 2 setup cells
paco-barreras 57a0af2
Merge branch 'main' into darren-contact-sip
paco-barreras 2890b3a
Import of earth radius constant instead of declaring
paco-barreras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if both user ids are missing, would this evaluate to true? Then we would get a false contact? Not sure if/where we check for missing user_ids