feat: add MiniMax subagent provider - #293
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (13)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesMiniMax local agent support
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR adds MiniMax support through the existing provider and execution controls without introducing a demonstrated merge-blocking risk. It is merge-ready after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant Driver as MiniMaxLocalAgentDriver
participant Registry as MiniMaxModelRegistry
participant Factory as defaultPiSessionFactory
Driver->>Registry: Register regional MiniMax providers
Driver->>Registry: Resolve authenticated model
Driver->>Factory: Create runtime with MiniMax context
Factory->>Registry: Resolve configured model
Factory-->>Driver: Return PiSessionRuntime
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 9 files. (4 skipped: 4 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds MiniMax as an embedded local subagent provider, including global and China endpoint selection, MiniMax-M3 and MiniMax-M2.7 metadata, provider discovery, schema and documentation updates, and focused regression coverage.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code-triggered failures identified. The provider is consistently registered across runtime discovery, availability, profiles, schema, and documentation, while focused tests cover regional model selection and runtime execution.
|
| Filename | Overview |
|---|---|
| src/local-agent-minimax.ts | Implements MiniMax regional provider registration, model metadata, authenticated endpoint selection, and the provider-specific embedded driver. |
| src/local-agent-pi.ts | Generalizes the embedded Pi driver and runtime to support provider-specific defaults, model registration, model resolution, errors, and runtime keys. |
| src/local-agent-adapters.ts | Registers the new MiniMax driver in the local-agent driver collection. |
| src/local-agent-profiles.ts | Adds MiniMax to the supported provider type, discovery list, and validation message. |
| src/local-agent-minimax.test.ts | Covers endpoint and model metadata, provider registration, regional auth selection, model resolution, and the basic runtime lifecycle. |
| schema/v1/devspace.schema.json | Adds MiniMax to the configuration schema’s accepted local-agent providers. |
| docs/configuration.md | Documents MiniMax profile configuration, supported models, credentials, and regional endpoints. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Profile[MiniMax agent profile] --> Drivers[Local agent driver registry]
Drivers --> MiniMax[MiniMax driver]
MiniMax --> PiRuntime[Embedded Pi session runtime]
PiRuntime --> Registry[MiniMax model registry]
Registry --> Auth{Configured regional auth}
Auth -->|MINIMAX_API_KEY| Global[Global MiniMax endpoint]
Auth -->|MINIMAX_CN_API_KEY| China[China MiniMax endpoint]
Reviews (1): Last reviewed commit: "feat: add MiniMax subagent provider" | Re-trigger Greptile
Reason: Add MiniMax as a supported local subagent provider with current global and China model configuration.
This adds a native
minimaxtarget backed by the existing embedded runtime, registers MiniMax-M3 and MiniMax-M2.7 with current context, pricing, modality, and thinking metadata, and selects the authenticated global or China endpoint. It also updates provider discovery, the generated configuration schema, documentation, and focused regression coverage.Verified with
pnpm typecheck,pnpm test, andpnpm build.Summary by CodeRabbit
New Features
Documentation
Tests