Skip to content

feat: add MiniMax subagent provider - #293

Open
octo-patch wants to merge 1 commit into
Waishnav:mainfrom
octo-patch:octo/20260902-provider-add-recvtQw3gN0ETw
Open

feat: add MiniMax subagent provider#293
octo-patch wants to merge 1 commit into
Waishnav:mainfrom
octo-patch:octo/20260902-provider-add-recvtQw3gN0ETw

Conversation

@octo-patch

@octo-patch octo-patch commented Sep 2, 2026

Copy link
Copy Markdown

Reason: Add MiniMax as a supported local subagent provider with current global and China model configuration.

This adds a native minimax target backed by the existing embedded runtime, registers MiniMax-M3 and MiniMax-M2.7 with current context, pricing, modality, and thinking metadata, and selects the authenticated global or China endpoint. It also updates provider discovery, the generated configuration schema, documentation, and focused regression coverage.

Verified with pnpm typecheck, pnpm test, and pnpm build.

Summary by CodeRabbit

  • New Features

    • Added MiniMax as a supported local agent provider.
    • Added support for MiniMax-M3 and MiniMax-M2.7 models, including global and China endpoints.
    • Added authentication-based model selection and configurable thinking modes.
    • Added a MiniMax agent example configuration.
  • Documentation

    • Documented MiniMax provider setup, supported models, endpoints, credentials, and effort settings.
  • Tests

    • Added coverage for MiniMax availability, registration, authentication, execution, responses, and cleanup.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: cc518fd7-6f1f-42fa-955b-1291f2e9dcda

📥 Commits

Reviewing files that changed from the base of the PR and between 69a00ee and 65e2c7a.

📒 Files selected for processing (13)
  • docs/agent-profile-schema.md
  • docs/configuration.md
  • examples/agents/minimax-builder.md
  • schema/v1/devspace.schema.json
  • src/local-agent-adapters.test.ts
  • src/local-agent-adapters.ts
  • src/local-agent-availability.test.ts
  • src/local-agent-availability.ts
  • src/local-agent-errors.ts
  • src/local-agent-minimax.test.ts
  • src/local-agent-minimax.ts
  • src/local-agent-pi.ts
  • src/local-agent-profiles.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Changes

MiniMax local agent support

Layer / File(s) Summary
Provider contracts and configuration
src/local-agent-profiles.ts, schema/v1/devspace.schema.json, docs/..., examples/agents/minimax-builder.md
Adds minimax to provider validation, schema values, configuration examples, agent profiles, and provider documentation.
Configurable Pi runtime
src/local-agent-pi.ts
Adds configurable providers, model resolvers, registry setup, default models, and provider-specific error messages.
MiniMax models and runtime
src/local-agent-minimax.ts, src/local-agent-minimax.test.ts
Adds regional endpoints, MiniMax model metadata, model resolution, provider registration, runtime execution, and focused tests.
Driver wiring and validation
src/local-agent-adapters.ts, src/local-agent-availability.ts, src/local-agent-errors.ts, src/*test.ts
Registers the MiniMax driver, detects availability, formats its display name, and verifies adapter and availability behavior.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 65e2c

This PR adds MiniMax support through the existing provider and execution controls without introducing a demonstrated merge-blocking risk. It is merge-ready after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant Driver as MiniMaxLocalAgentDriver
  participant Registry as MiniMaxModelRegistry
  participant Factory as defaultPiSessionFactory
  Driver->>Registry: Register regional MiniMax providers
  Driver->>Registry: Resolve authenticated model
  Driver->>Factory: Create runtime with MiniMax context
  Factory->>Registry: Resolve configured model
  Factory-->>Driver: Return PiSessionRuntime
Loading

Suggested reviewers: waishnav

Poem

A rabbit found a model bright
With regional paths and thinking light
The driver hopped into the flow
While tests checked each step below
MiniMax now joins the show

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 9 files. (4 skipped: 4… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding MiniMax as a subagent provider.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 9 files. (4 skipped: 4 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown

Greptile Summary

Adds MiniMax as an embedded local subagent provider, including global and China endpoint selection, MiniMax-M3 and MiniMax-M2.7 metadata, provider discovery, schema and documentation updates, and focused regression coverage.

  • Generalizes the existing Pi runtime so provider-specific model registration and resolution can be reused by MiniMax.
  • Registers regional MiniMax providers and selects an authenticated endpoint for unqualified model references.
  • Adds MiniMax availability, profile, documentation, example, and runtime tests.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code-triggered failures identified.

The provider is consistently registered across runtime discovery, availability, profiles, schema, and documentation, while focused tests cover regional model selection and runtime execution.

Important Files Changed

Filename Overview
src/local-agent-minimax.ts Implements MiniMax regional provider registration, model metadata, authenticated endpoint selection, and the provider-specific embedded driver.
src/local-agent-pi.ts Generalizes the embedded Pi driver and runtime to support provider-specific defaults, model registration, model resolution, errors, and runtime keys.
src/local-agent-adapters.ts Registers the new MiniMax driver in the local-agent driver collection.
src/local-agent-profiles.ts Adds MiniMax to the supported provider type, discovery list, and validation message.
src/local-agent-minimax.test.ts Covers endpoint and model metadata, provider registration, regional auth selection, model resolution, and the basic runtime lifecycle.
schema/v1/devspace.schema.json Adds MiniMax to the configuration schema’s accepted local-agent providers.
docs/configuration.md Documents MiniMax profile configuration, supported models, credentials, and regional endpoints.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Profile[MiniMax agent profile] --> Drivers[Local agent driver registry]
  Drivers --> MiniMax[MiniMax driver]
  MiniMax --> PiRuntime[Embedded Pi session runtime]
  PiRuntime --> Registry[MiniMax model registry]
  Registry --> Auth{Configured regional auth}
  Auth -->|MINIMAX_API_KEY| Global[Global MiniMax endpoint]
  Auth -->|MINIMAX_CN_API_KEY| China[China MiniMax endpoint]
Loading

Reviews (1): Last reviewed commit: "feat: add MiniMax subagent provider" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant