Skip to content

Archive archiver logs in the data dir and log at info level - #32

Merged
hsoerensen merged 1 commit into
mainfrom
archiver-log-rotation
Nov 7, 2026
Merged

hsoerensen merged 1 commit into
mainfrom
archiver-log-rotation

Conversation

@hsoerensen

@hsoerensen hsoerensen commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Change (archiver profile on mainnet, testnet and betanet)

  • LogArchiveDir: /algod/data: LogArchiveDir defaults to ColdDataDir, so rotation copies the full log to cold storage. That can be slow when cold storage is on network storage. Archiving into the data dir makes rotation a local rename.
  • BaseLoggerDebugLevel: 3 (was 4): info level instead of debug, so the log rotates far less often.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 7, 2026 01:49
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 077e9b1d-cc7d-4a64-90b9-3cfdc6d4829a
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to complete this review at the selected tier due to model policy or plan restrictions.

🔵 Needs a closer look

This changes production archiver logging behavior and depends on runtime/environment specifics (algod v5.0.4 support for LogArchiveDir plus ensuring /algod/data is local, writable, and has sufficient space), so deployment validation is needed before proceeding.

No open issues 🎉

What changed in this PR

This pull request updates the archiver algod configuration (mainnet/testnet/betanet) to prevent log rotation from archiving large node.log files onto NFS-backed cold storage, which previously caused stalls and extended downtime.

Changes:

  • Set LogArchiveDir to /algod/data so log rotation archives stay on local disk instead of defaulting to ColdDataDir (NFS).
  • Reduce BaseLoggerDebugLevel from 4 to 3 to slow log growth and reduce rotation frequency.
File Summary
configuration/​testnet/​archiver/​config.json Moves log archive output to /algod/data and lowers debug verbosity for the testnet archiver profile.
configuration/​mainnet/​archiver/​config.json Moves log archive output to /algod/data and lowers debug verbosity for the mainnet archiver profile.
configuration/​betanet/​archiver/​config.json Moves log archive output to /algod/data and lowers debug verbosity for the betanet archiver profile.

Review effort: Balanced

LogArchiveDir defaults to ColdDataDir, so log rotation copies a full
LogSizeLimit-sized file to cold storage, which can be slow when cold storage
is on network storage. Archive into the data dir instead, and use info (3)
instead of debug (4) logging.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@hsoerensen
hsoerensen force-pushed the archiver-log-rotation branch from 28d29d9 to d44cf94 Compare November 7, 2026 02:01
@hsoerensen hsoerensen changed the title Keep archiver log rotation off the NFS cold storage Archive archiver logs in the data dir and log at info level Nov 7, 2026
@hsoerensen
hsoerensen merged commit 14cbf9f into main Nov 7, 2026
18 of 19 checks passed
@hsoerensen
hsoerensen deleted the archiver-log-rotation branch November 7, 2026 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants