Repository navigation
Conversation
SimonDarksideJ
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A Graphic using
SoftMaskScriptbeneath a parent uGUIMaskcan render with stale soft-mask parameters. The CanvasRenderer may use a cached stencil material derived from the Graphic's material, whileSetMask()only updates the original material. This can leave the Graphic invisible on its first display and prevent later mask parameter changes from reaching the rendered material.Changes
ApplyMask().Breaking Changes
None. No public API or serialized field changes.
Related Submodule Changes
None.
Testing status
No automated tests have been added. The diff is limited to
Runtime/Scripts/Effects/SoftMaskScript.csand preserves the upstream text handling and file line endings.git diff --checkpasses with CRLF recognized as line endings.Manual testing status
The change addresses a first-display visibility problem encountered in a Unity 2022.3 project. I have not run a fresh Unity compilation or visual regression test for this upstream contribution. The available Unity MCP connection points to a different project, and script validation rejects the standalone package checkout because it is outside that project's Assets directory.
Suggested manual verification: