Repository navigation
Conversation
The Disabled / Scroll To End / Auto dropdown was confusing, since Scroll To End only differed from Auto by locking the scrollbar. It's now a single toggle button which shows whether new messages are followed: scrolling up or keyboard selection turns it off, scrolling to the last message or clicking it turns it back on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The vertical scrollbar is always shown so the corner is always there, and both scrollbars are slightly thicker to give the toggle more room. The icon is redrawn as a flat arrow like the scrollbar's own, tinted for the current skin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Harness Review
The change replaces the scroll-mode dropdown with a corner toggle and a saved boolean setting. I examined scrolling, keyboard navigation, settings compatibility, surrounding layout and update behavior, scrollbar styles, and the new icon; no actionable issues were substantiated.
Reviewed commit 3af8aa0
🤖 Helpful? 👍/👎
|
I have some concern about user experience. Before when setting was "Auto", a user may scroll up to view some older messages which stopped scrolling but didn't change "Auto" logic. So next time the logcat window was opened messages were automatically scrolling again. Now if a user scrolls up, scrolling is being turned off completely. So next time the window is opened, there is no scroll and it can be not really obvious what the user should do to resume scrolling. What if you save this setting only when the user presses the icon explicitly? |
There was a problem hiding this comment.
Claude says that the icon might be too big, so it's being scaled down and it may look not really nice.
| else if (e.type == EventType.ScrollWheel && e.delta.y < 0.0f) | ||
| m_ScrollData.PerformScrollWhileInAuto = false; | ||
| } | ||
| if (scrollChanged || (e.type == EventType.ScrollWheel && e.delta.y > 0.0f)) |
There was a problem hiding this comment.
Is scrollChanged true, when scrolling horizontally? If yes, there can be some unexpected effect when user turns scrolling off being at the end of the logcat messages, then scrolls horizontally and this turns scrolling back on.
|
|
||
| int minVisible = (int)(m_ScrollPosition.y * scalar); | ||
| int maxVisible = minVisible + maxVisibleItems; | ||
| // Do the scrolling in repain event since maxVisibleItems depends on visibleWindowRect |
Purpose of PR
Type of change:
20261120-1514-19.5275706.mp4
Addresses feedback that the Scroll dropdown below the message log (Disabled / Scroll To End / Auto) was confusing. Scroll To End only differed from Auto by locking the scrollbar, and there was no quick way to jump to the last message during heavy log activity.
The dropdown is replaced by a single Auto Scroll toggle button in the corner between the message log's horizontal and vertical scrollbars:
Editor/Textures/DownArrowToLine.png) is a flat arrow over a line, like the scrollbar's own arrow. It's tinted for the current skin and faded while off.Other changes:
m_AutoScrollEnabled, replacing theAutoScrollenum. It has a new name so values saved by earlier versions aren't misread. Everyone starts with Auto Scroll on after upgrading.Links to Jira/Fogbugz cases
PLAT-23901
Halo effect
Only the message log: scrolling, keyboard navigation, the scrollbars and the column borders. The status bar row no longer contains the Scroll dropdown.
Checklist for PR maker
Testing status
AndroidLogcatAutoScrollTestscoverIsLastEntryVisible, which is unchanged. Not run on this branch yet.🤖 Generated with Claude Code