Skip to content

Fix PVP-124-2 failures and bump to 1.5.1 - #243

Open
todi1856 wants to merge 2 commits into
masterfrom
remove-trailing-whitespace
Open

todi1856 wants to merge 2 commits into
masterfrom
remove-trailing-whitespace

Conversation

@todi1856

@todi1856 todi1856 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Yamato CI Docs preview

Package validation for 1.5.0 failed PVP-124-2 (text files should not have trailing spaces or tabs at the end of lines) on three files:

  • CHANGELOG.md
  • Documentation~/TableOfContents.md
  • Tests/Editor/LogMessageByShellDumpsys.txt

Changes

  • Strip trailing spaces from CHANGELOG.md and Documentation~/TableOfContents.md.
  • Rename the LogMessageByShellDumpsys.txt test fixture to .log rather than editing it, so it keeps the exact dumpsys output captured from the device. The PVP text file checks only cover a fixed list of extensions, and .log isn't one of them. Its .meta keeps the same GUID and now uses DefaultImporter, which is what Unity assigns to .log files.
  • Update AndroidLogcatPerformanceTests, the only code that reads the fixture, to the new path.
  • Bump the package version to 1.5.1.

Testing

  • Scanned the package's PVP text files (by the check's extension list) for trailing whitespace, CRLF and tabs. No new issues; QAReport.md has trailing spaces but is excluded by .npmignore.
  • Tests not run locally; relying on Yamato CI and package validation.

🤖 Generated with Claude Code

todi1856 and others added 2 commits November 19, 2026 16:37
Strip trailing spaces from CHANGELOG.md and Documentation~/TableOfContents.md.

Rename the LogMessageByShellDumpsys.txt test fixture to .log instead of
editing it, so it keeps the exact output captured from the device. PVP's
text file checks only cover a fixed list of extensions, and .log is not
one of them. Its .meta now uses DefaultImporter, which is what Unity
assigns to .log files.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@todi1856
todi1856 enabled auto-merge November 19, 2026 14:38

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

I reviewed the whitespace cleanup, 1.5.1 release metadata, and fixture rename, including its only reader and preserved asset GUID. I found no actionable issues.

Reviewed commit 4cf3636

🤖 Helpful? 👍/👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant