Repository navigation
trunk shadow changes: com.unity.mobile.android-logcat - #230
pets-svc[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
💡 Harness Review
The loaded-assembly inspection removes the CoreCLR-incompatible reflection call, but the revised reference expectations do not preserve compatibility with supported older Editors.
Reviewed commit a54c33f
🤖 Helpful? 👍/👎
| "Unity.Scripting", | ||
| "UnityEngine.TypeRegistryModule", |
There was a problem hiding this comment.
ValidateAssemblyReferences now fails on supported older Editors, including the Unity 2021.3 validation job. Those Editors do not reference the newly introduced assemblies, such as Unity.Scripting and UnityEngine.TypeRegistryModule. Adding these names to expectedReferences makes them mandatory because the final assertion requires every reference count to equal one. The test assembly has no Editor-version constraint, so older CI jobs still execute this check. Select the expected references by Editor version while retaining the loaded-assembly inspection.
🤖 Helpful? 👍/👎
a54c33f to
2e98361
Compare
|
Closing, since #232 was merged as a substitute |
This PR contains changes made to the
trunkcopy ofcom.unity.mobile.android-logcat.This usually means that breaking changes has landed in the
trunkEditor, necessitating matching changes to your package code.trunkis therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.
Note: The
shadow-package/com.unity.mobile.android-logcatbranch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened, and any assignees copied over.