Skip to content

trunk shadow changes: com.unity.mobile.android-logcat - #230

Closed
pets-svc[bot] wants to merge 1 commit into
masterfrom
shadow-package/com.unity.mobile.android-logcat
Closed

pets-svc[bot] wants to merge 1 commit into
masterfrom
shadow-package/com.unity.mobile.android-logcat

Conversation

@pets-svc

@pets-svc pets-svc Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

This PR contains changes made to the trunk copy of com.unity.mobile.android-logcat.

This usually means that breaking changes has landed in the trunk Editor, necessitating matching changes to your package code. trunk is therefore currently running CI tests with the modified shadow package instead of your real package. You must integrate these changes into your package (while maintaining compatibility with older versions of Unity supported by your package), release a new version, and land the new version in the editor manifest before the Package RC deadline, as your package otherwise will not be compatible with the released Editor.

Is this automation useful? Let us know on #devs-pets, where you can also ask any question you might have about shadow packages or this automation.

Note: The shadow-package/com.unity.mobile.android-logcat branch may be force-pushed by automation at any time. If you want to make changes before landing this PR, create your own branch (and PR) to avoid automation overwriting your changes:

git fetch origin shadow-package/com.unity.mobile.android-logcat:mybranch
git checkout mybranch

If further changes are made to the shadow package on trunk, this PR will be updated if still open, or else a new PR will be opened, and any assignees copied over.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Needs changes

The loaded-assembly inspection removes the CoreCLR-incompatible reflection call, but the revised reference expectations do not preserve compatibility with supported older Editors.

Reviewed commit a54c33f

🤖 Helpful? 👍/👎

Comment on lines +51 to +52
"Unity.Scripting",
"UnityEngine.TypeRegistryModule",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

ValidateAssemblyReferences now fails on supported older Editors, including the Unity 2021.3 validation job. Those Editors do not reference the newly introduced assemblies, such as Unity.Scripting and UnityEngine.TypeRegistryModule. Adding these names to expectedReferences makes them mandatory because the final assertion requires every reference count to equal one. The test assembly has no Editor-version constraint, so older CI jobs still execute this check. Select the expected references by Editor version while retaining the loaded-assembly inspection.

🤖 Helpful? 👍/👎

@pets-svc
pets-svc Bot force-pushed the shadow-package/com.unity.mobile.android-logcat branch from a54c33f to 2e98361 Compare October 29, 2026 17:40
@todi1856

Copy link
Copy Markdown
Member

Closing, since #232 was merged as a substitute

@todi1856 todi1856 closed this Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant