Repository navigation
fix: validate reused release sync snapshots - #377
Merged
Merged
Conversation
This was referenced Nov 5, 2026
angelayzheng
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
A precreated or replaced
automation/sync-main-*branch could pass snapshot validation even when its tree did not represent the merge of its recorded parents. An older staging parent could roll back released files; a snapshot could also discard a production-only hotfix while recordingmainas merged. This addresses the P1 review on #374.Snapshot validation now recomputes
git merge-tree --write-tree <first-parent> <main>and requires that result to match the snapshot. Conflicts and mismatches stop before opening or merging a sync PR. It also verifies that merging the snapshot into current staging preserves staging's exact tree, catching a production-revert case even when the snapshot matches its own parents. The validation runs again immediately before a merge. Valid snapshots remain reusable after staging advances, preserving concurrent changes and intentional reverts.Changed-file rationale
.github/scripts/promotion.cjs.github/scripts/promotion.test.cjsScope stays within
.github. There are no configuration, migration or deployment changes. The workflow must receive this fix before promotion tomain.Validation
Fresh CI passed on
286ed790b0699dff7c5163a762dc0cfcb912f5d4.make test-release test-promotionpassed, including conflict rejection and valid retry/concurrent-staging cases.make checkpassed with locked dependencies and Python imports pinned to this worktree.git diff --checkpassed. Tests use disposable local Git repositories and fake GitHub calls; no live sync or production promotion was performed.