Skip to content

chore(tools): Rename novaMock to novaSim and externalize control UI - #13

Merged
Awesome-Ace22 merged 3 commits into
devfrom
chore/rename-novamock
Oct 30, 2026
Merged

Awesome-Ace22 merged 3 commits into
devfrom
chore/rename-novamock

Conversation

@Awesome-Ace22

@Awesome-Ace22 Awesome-Ace22 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

What and why

This pull request renames the main simulator from novaMock.py to novaSim.py throughout the codebase and documentation. All references, scripts, tests, and documentation have been updated to use the new name. This improves clarity and consistency, reflecting the simulator's purpose more accurately.

Simulator Renaming and Consistency Updates:

  • Renamed all references to novaMock.py to novaSim.py in documentation files such as README.md, CONTRIBUTING.md, and docs/tools.md, and updated related descriptions to clarify the simulator’s role and UI features. [1] [2] [3] [4]
  • Updated CI workflow, test markers, and integration test fixtures to use novaSim.py instead of novaMock.py, ensuring that automated and manual testing processes reference the correct simulator. [1] [2] [3] [4] [5]
  • Renamed the integration test file from test_novamock_e2e.py to test_novasim_e2e.py and updated all internal references and fixtures accordingly. [1] [2] [3]
  • Updated development scripts (dev_windows.ps1) to launch novaSim.py and print the correct process name.
  • Updated internal comments and documentation in fas_bridge.py to reference novaSim.py for state synchronization.

How was this tested?

  • 1 Unit / Automated Test - CI
  • 2 Simulator Test - testing procedure with the hardware simulators
  • 3 Bench Test - testing procedure on the dev stack, with some real hardware
  • 4 Integration Test - full engine test procedure, real hardware, no propellants

Hardware impact

  • None - UI, docs or tooling only
  • Changes how a sensor is read, converted or shown
  • Changes how an actuator is commanded, or safety rules, interlocks, timeouts or sequencing → add the hardware-risk label; a lead must approve
  • Changes a message format, MQTT topic or FAS protocol that another repo depends on → title needs !, link the matching PRs:

Checklist

  • Targets dev (or main for a release/hotfix, or with a reason given above)
  • Branch is up to date ("Update branch" button)
  • No station config/calibrations, data files, secrets, .env files or build output committed
  • README/docs updated if behaviour changed

Update simulator naming, MQTT client ID, logs, usage examples, and integration test references. Load the control UI from sim_control.html on each request so edits appear on refresh.
@Awesome-Ace22
Awesome-Ace22 requested a review from a team as a code owner October 30, 2026 21:24
@Awesome-Ace22
Awesome-Ace22 merged commit 467c2a1 into dev Oct 30, 2026
2 of 8 checks passed
@Awesome-Ace22
Awesome-Ace22 deleted the chore/rename-novamock branch October 30, 2026 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant