Skip to content

fix(config): show missing relay_type, range and zero_offset fields - #9

Merged
Awesome-Ace22 merged 2 commits into
devfrom
bugfix/config-missing-fields
Oct 20, 2026
Merged

Awesome-Ace22 merged 2 commits into
devfrom
bugfix/config-missing-fields

Conversation

@Awesome-Ace22

@Awesome-Ace22 Awesome-Ace22 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

What and why

The config editor was missing fields the backend config already has, so they couldn't be edited and could be lost on save. relay_type is now shown for servos and solenoids as well as powered devices (one shared relayTypeField). Sensors get an editable min/max Range column. zero_offset is added to the ConvertMethod type and the Convert dropdown.

Closes UTATRocketry/Nova-Collected#24

How was this tested?

  • 1 Unit / Automated Test - CI
  • 2 Simulator Test - testing procedure with the hardware simulators
  • 3 Bench Test - testing procedure on the dev stack, with some real hardware
  • 4 Integration Test - full engine test procedure, real hardware, no propellants

Hardware impact

  • None - UI, docs or tooling only
  • Changes how a sensor is read, converted or shown
  • Changes how an actuator is commanded, or safety rules, interlocks, timeouts or sequencing → add the hardware-risk label; a lead must approve
  • Changes a message format, MQTT topic or FAS protocol that another repo depends on → title needs !, link the matching PRs:

This only changes the config editor UI. It lets you set a sensor's convert method and range and an actuator's relay type, and those values drive how the backend reads and converts sensors.

Checklist

  • Targets dev (or main for a release/hotfix, or with a reason given above)
  • Branch is up to date ("Update branch" button)
  • No station config/calibrations, data files, secrets, .env files or build output committed
  • README/docs updated if behaviour changed

@Awesome-Ace22 Awesome-Ace22 added the bug Something isn't working label Oct 20, 2026
@Awesome-Ace22 Awesome-Ace22 self-assigned this Oct 20, 2026
@Awesome-Ace22
Awesome-Ace22 merged commit b6923ee into dev Oct 20, 2026
2 of 4 checks passed
@Awesome-Ace22
Awesome-Ace22 deleted the bugfix/config-missing-fields branch October 20, 2026 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add relay_type to solenoids in the config editor and check for other missing fields

1 participant