Repository navigation
fix(config): show missing relay_type, range and zero_offset fields - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The config editor was missing fields the backend config already has, so they couldn't be edited and could be lost on save.
relay_typeis now shown for servos and solenoids as well as powered devices (one sharedrelayTypeField). Sensors get an editable min/max Range column.zero_offsetis added to theConvertMethodtype and the Convert dropdown.Closes UTATRocketry/Nova-Collected#24
How was this tested?
Hardware impact
hardware-risklabel; a lead must approve!, link the matching PRs:This only changes the config editor UI. It lets you set a sensor's convert method and range and an actuator's relay type, and those values drive how the backend reads and converts sensors.
Checklist
dev(ormainfor a release/hotfix, or with a reason given above).envfiles or build output committed