Repository navigation
fix(scripts): store executable bit on pi scripts - #15
Merged
Merged
Conversation
…rt scripts executable
…t for compatibility
Awesome-Ace22
added
bug
Awesome-Ace22
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issues with script executability after git checkouts, especially for older releases that did not store the executable bit on scripts. It introduces a helper function to restore executable permissions, updates deployment and build processes to use this helper, and ensures the systemd service works even if the executable bit is missing.
Script Executability Improvements:
make_executable()helper function innova-pi.shto restore the executable bit on.shscripts after git checkouts, addressing issues from older releases.chmodcalls withmake_executable()insetup_units(),do_update(), anddo_deploy()to consistently ensure scripts are executable in both production and development directories. [1] [2] [3]Systemd Service Robustness:
ExecStartline innovaGround@.serviceto explicitly invokestart.shvia/bin/bash, so the service works even ifstart.shis missing its executable bit.Build Process User Ownership:
do_build()to detect and report cases where the build directory contains files owned by another user, guiding the user to rebuild withsudoif necessary.