Repository navigation
Conversation
|
Please set a versioning label of either |
oskarhurst
requested changes
Oct 6, 2026
oskarhurst
left a comment
oskarhurst
left a comment
There was a problem hiding this comment.
Make sure to add selectedIndex and onChange to the tabs props table in the docs.
| onChange, | ||
| }) { | ||
| const controlledProps = | ||
| selectedIndex === undefined ? {} : { selectedIndex, onChange }; |
There was a problem hiding this comment.
You should probably forward onChange even if a tab is not selected. That way any future improvements can use it.
|
|
||
| function Component() { | ||
| return ( | ||
| <div> |
There was a problem hiding this comment.
Make sure to wrap this in an absolute height so that the map will render
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tabsselection withselectedIndexandonChangemainRelated: #136
Screenshots
Controlled tabs embedded beneath the SWT status map, with the selected project summary rendered in place:
Validation
npm run lintnpm test -- --run(2 files, 8 tests)npm run buildDependency
Release dependency
A new patch release is needed after merge so the SWT application can consume controlled tabs from the registry.