Repository navigation
CDA-138 - Adds Element DTOs for rating components and updating ratings json util to use jackson - #1994
Merged
rma-bryson merged 1 commit intoOct 8, 2026
Conversation
…s json util to use jackson
rma-bryson
force-pushed
the
bugfix/CDA-138-update-ratings-util-to-use-jackson
branch
from
October 7, 2026 21:20
4e67d80 to
acf3b45
Compare
rma-bryson
marked this pull request as ready for review
October 8, 2026 15:26
MikeNeilson
approved these changes
Oct 8, 2026
MikeNeilson
left a comment
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
This really makes me wonder why we don't just have these annotations over in the ratings project (don't do it, we're slowly moving that work to opendcs-ratings)
My comment about using the RatingsDocument in the content from is somewhat questionable. I was having issues with it in the typescript client creation as I had updated several libraries and the behavior changes but we probably want to spend some time to confirm it would actually render the example/schema there correctly.
Contributor
There was a problem hiding this comment.
The RatingsDocument should be added as the from = in the requestBody specification in the headers
rma-bryson
deleted the
bugfix/CDA-138-update-ratings-util-to-use-jackson
branch
October 8, 2026 17:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed javax.xml and replaces with jackson - including DTO representation for various components.
Related Issue
Related to #1804
Validation
Included unit tests and existing integration test coverage
Checklist