Skip to content

Give the homepage definition and video separate scroll steps - #4

Merged
juancobo merged 2 commits into
mainfrom
fix/homepage-video-stop
Nov 1, 2026
Merged

juancobo merged 2 commits into
mainfrom
fix/homepage-video-stop

Conversation

@juancobo

@juancobo juancobo commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

The homepage's definition text and demonstration shared an oversized section. At its scroll stop, the film extended below the window. Wheel and trackpad input also moved continuously between sections.

Give “What is Telar?” and the demonstration their own consecutive scroll steps, preserving the existing English and Spanish copy. Fit the complete 16:9 film to both the window width and height. Smaller screens keep compact sections.

A wheel/trackpad gesture now advances one stop through the same bounded animation as the arrow keys. Ignore the gesture's momentum tail while that move completes. Tall sections include reading stops so their lower content remains reachable. Use layout positions for navigation so fade-in transforms cannot introduce extra stops. Native snap points and a scroll-event handoff also cover input inside the Vimeo iframe while retaining its own controls.

Validation: production and preview Hugo builds, site verification, git diff --check, and browser checks of English/Spanish, short desktop windows, mobile sizing, wheel gestures and arrow-key navigation.

Copilot AI balanced review requested due to automatic review settings November 1, 2026 21:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block approval of the homepage video and scroll-navigation changes.

No open issues 🎉

What changed in this PR

This PR gives the homepage demonstration video its own scroll stop, keeping the complete film visible while moving the bilingual definition into the features introduction.

Changes:

  • Constrain the video by viewport width and height, with compact spacing on smaller screens.
  • Move the English and Spanish definition text into the features section.
  • Calculate arrow-key scroll targets from layout positions so fade-in transforms do not introduce extra stops.
File Description
static/​assets/​homepage-demo/​homepage-demo.js Use layout offsets for element scroll targets and arrow-key stops.
static/​assets/​homepage-demo/​homepage-demo.css Add viewport-based video sizing and adjust responsive spacing and definition styles.
layouts/​_partials/​landing-body.html Place the bilingual definition above the key features.
layouts/​_partials/​homepage-demo.html Remove the visible definition while retaining a visually hidden section heading.

Review effort: Balanced

@juancobo juancobo changed the title Keep the homepage video within one scroll stop Give the homepage definition and video separate scroll steps Nov 1, 2026
@juancobo
juancobo merged commit 8f3dbbf into main Nov 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants