Repository navigation
Give the homepage definition and video separate scroll steps - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block approval of the homepage video and scroll-navigation changes.
No open issues 🎉
What changed in this PR
This PR gives the homepage demonstration video its own scroll stop, keeping the complete film visible while moving the bilingual definition into the features introduction.
Changes:
- Constrain the video by viewport width and height, with compact spacing on smaller screens.
- Move the English and Spanish definition text into the features section.
- Calculate arrow-key scroll targets from layout positions so fade-in transforms do not introduce extra stops.
| File | Description |
|---|---|
static/assets/homepage-demo/homepage-demo.js |
Use layout offsets for element scroll targets and arrow-key stops. |
static/assets/homepage-demo/homepage-demo.css |
Add viewport-based video sizing and adjust responsive spacing and definition styles. |
layouts/_partials/landing-body.html |
Place the bilingual definition above the key features. |
layouts/_partials/homepage-demo.html |
Remove the visible definition while retaining a visually hidden section heading. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The homepage's definition text and demonstration shared an oversized section. At its scroll stop, the film extended below the window. Wheel and trackpad input also moved continuously between sections.
Give “What is Telar?” and the demonstration their own consecutive scroll steps, preserving the existing English and Spanish copy. Fit the complete 16:9 film to both the window width and height. Smaller screens keep compact sections.
A wheel/trackpad gesture now advances one stop through the same bounded animation as the arrow keys. Ignore the gesture's momentum tail while that move completes. Tall sections include reading stops so their lower content remains reachable. Use layout positions for navigation so fade-in transforms cannot introduce extra stops. Native snap points and a scroll-event handoff also cover input inside the Vimeo iframe while retaining its own controls.
Validation: production and preview Hugo builds, site verification,
git diff --check, and browser checks of English/Spanish, short desktop windows, mobile sizing, wheel gestures and arrow-key navigation.