Repository navigation
feat: DNG remote capture, with the JPEG of the same exposure - #5
Merged
Merged
Conversation
shoot(stream=True, dng=True) raised NotImplementedError, because CHDK sends a DNG as two transfers, the header and the raw data, and the library fetched one format. It now asks for both, fetches each as the camera offers it, and returns a complete DNG. With jpeg=True it asks for the JPEG too and returns a DngCapture with .dng and .jpeg, both from one exposure and one script. assemble_dng builds the file from the two parts: it reads the strip offsets and sizes from the header, swaps the byte pairs of the raw data, makes the thumbnail the header describes from the raw data, and refuses a header it cannot read or raw data of another length. It uses the standard library only. The streamed JPEG path sends what it sent before. Run on two Canon PowerShot A2500s under CHDK 1.5.1, one capture each: 4.2 s and 4.1 s for the DNG and the JPEG together, and both DNGs open in macOS. Repeated captures and other viewers are not yet tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shoot(stream=True, dng=True) raised NotImplementedError, because CHDK
sends a DNG as two transfers, the header and the raw data, and the
library fetched one format. It now asks for both, fetches each as the
camera offers it, and returns a complete DNG. With jpeg=True it asks
for the JPEG too and returns a DngCapture with .dng and .jpeg, both
from one exposure and one script.
assemble_dng builds the file from the two parts: it reads the strip
offsets and sizes from the header, swaps the byte pairs of the raw
data, makes the thumbnail the header describes from the raw data, and
refuses a header it cannot read or raw data of another length. It uses
the standard library only.
The streamed JPEG path sends what it sent before.
Run on two Canon PowerShot A2500s under CHDK 1.5.1, one capture each:
4.2 s and 4.1 s for the DNG and the JPEG together, and both DNGs open
in macOS. Repeated captures and other viewers are not yet tested.