Repository navigation
Release v0.4.0: email sign-in links - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sign-in by emailed link to the shared sign-in at
ampl.tools/auth, alongside GitHub.githubIdon the shared user record may benull; tools that read it must handle that.safeReturnTorejects a return path that normalizes to another origin.Migration.
0002_email_loginrebuildsusersandsessions(nullablegithub_id, uniqueemail) and addsemail_login_tokens. It is forward-only: D1 has no rollback, and an earlier Worker version cannot run against the new schema once email-only accounts exist. It refuses to run if two accounts share an email address.