Repository navigation
Keep published hours on listings past their review target - #26
Merged
Merged
Conversation
A listing whose source review is older than the configured interval no longer has its schedule replaced with "Review overdue — confirm details before travelling." It keeps its published hours, schedule badge and place in the today filter, and shows an asterisk beside its sources-checked date instead. Unconfirmed schedules, needs-review listings, temporary closures and out-of-range dates are still shown as uncertain. Docs, changelog and tests are updated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
When a listing's source review is older than
review.interval_days, the directory used to replace its schedule with "Review overdue — confirm details before travelling." in three places on the card: the badge detail, the Today row and a line under the sources-checked date. The badge also fell back to "Check hours before going" and the listing dropped out of the "Open now or later today" filter.Now such a listing:
<span class="review-due" data-review-due>), and nothing else.The "Review overdue" wording is removed from the public copy.
What does not change
Schedules that are unconfirmed, listings whose verification state is
needs_review, temporarily unavailable or closed services, dates outside a schedule's validity range, unconfirmed exceptions and jurisdiction warning dates are still shown as uncertain. The sources-checked date stays on every card. No listing data changes.Files
src/domain.ts:publishedScheduleno longer returnsunknownonly because the review is past its target.src/presentation.ts,src/copy/en.ts,src/styles.css: asterisk in place of the warning text.docs/configuration.md,docs/maintenance.md,CHANGELOG.md: describe the new behaviour (the changelog also records the visual refresh from Refresh the directory's visual design #25).tests/unit/domain.test.ts,tests/unit/presentation.test.ts: updated and extended.Checks
npm run check -- --all: unit and contract tests pass (84); browser tests pass in Chromium (32). Firefox and WebKit run in CI.