Repository navigation
Conversation
GitHub refuses to start a workflow whose caller grants less than any job of the called workflow requests, even a job it skips, so CI Go, CI Proto and CodeQL failed at startup on main. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
No actionable comments were generated in the recent review. WalkthroughThree GitHub Actions workflows now grant ChangesCaller workflow permissions
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Possibly related PRs
Merge Risk:
|
Note
Low Risk
GitHub Actions permission alignment only; callers still do not run the Baton/GCP steps that consume the token.
Overview
Fixes CI Go, CI Proto, and CodeQL failing to start when they call
ci-selection.yml, by grantingid-token: writeon each workflow’schangesreusable-workflow job (matching what CI Rust already had).GitHub compares the caller’s job permissions to every job in the called workflow—including the optional
runnerjob these suites skip—so missingid-token: writeblocked the whole run even though those callers never execute Baton/GCP steps.The workflow tests now assert all selection callers expose
id-token: write, with a comment documenting this GitHub behavior.Reviewed by Cursor Bugbot for commit fc0ea27. Bugbot is set up for automated code reviews on this repo. Configure here.