Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 22 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
2 times, most recently
from
November 9, 2026 07:42
8c912c9 to
c0dbac9
Compare
yordis
changed the title
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 613908c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
from
November 12, 2026 02:24
b80fcd2 to
1daab58
Compare
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
2 times, most recently
from
November 12, 2026 05:29
244a447 to
ae49e58
Compare
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
from
November 12, 2026 05:46
ae49e58 to
f6f5367
Compare
yordis
marked this pull request as ready for review
November 12, 2026 06:18
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
from
November 12, 2026 07:26
f6f5367 to
7f93d54
Compare
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
from
November 12, 2026 07:34
7f93d54 to
fed7ebf
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit fed7ebf. Configure here.
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
from
November 12, 2026 07:49
fed7ebf to
639203e
Compare
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
…r Bazel Bazel only creates test targets for files listed in integration_tests, so unlisted tests never run in the Bazel CI job. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/feat-claude-sdk-allowed-tools
branch
from
November 12, 2026 08:05
639203e to
0d2233d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Draft configuration-only API expansion with no runtime enforcement; behavior is covered by focused unit tests.
Overview
Exposes
allowed_toolsonClaudeAgentOptionsas an orderedVec<ToolRule>that defaults empty, aligned with upstream Pythonallowed_tools/ TypeScriptallowedTools.ToolRuleis a new string newtype (exported from the crate) that keeps rule text verbatim—empty strings, commas, newlines, NULs, and duplicates are not normalized or deduplicated at configuration time.README documents the field and clarifies that this API draft only stores rules; no permission policy or process-start validation runs here. Bazel adds
allowed_toolsandtool_rule_storageintegration tests, with unit tests covering list order/duplicates and edge-case string preservation.Reviewed by Cursor Bugbot for commit 0d2233d. Bugbot is set up for automated code reviews on this repo. Configure here.