You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep path configuration review separate from filesystem and process behavior.
Note
Medium Risk
Public option types change (model, env) and new env values default to sensitive, so callers may need updates even though this remains an API draft without runtime wiring.
Overview
Extends ClaudeAgentOptions with additional_directories (ordered Vec<PathBuf>, no canonicalization) to align with Python add_dirs / TypeScript additionalDirectories, with integration tests and Bazel coverage.
Refactors configuration types for safer Debug output: model becomes Option<ModelName> (model string hidden), env becomes an Environment map of ConfigValue entries that default to sensitive unless marked Plain (names visible, secrets as <redacted>). Adds SensitiveString, ConfigValue, Environment, and ModelName, exports them from the crate, and updates README and tests accordingly.
Reviewed by Cursor Bugbot for commit 785bda0. Bugbot is set up for automated code reviews on this repo. Configure here.
No actionable comments were generated in the recent review.
Walkthrough
The Claude Agent SDK adds a public additional_directories path list to ClaudeAgentOptions. The README documents its language-specific names and path behavior. An integration test checks the empty default and verifies that supplied paths remain unchanged and ordered.
ClaudeAgentOptions gains a public additional_directories: Vec<PathBuf> field.
Option documentation and validation rsworkspace/crates/platform/trogon-claude-agent-sdk/README.md, rsworkspace/crates/platform/trogon-claude-agent-sdk/BUILD.bazel, rsworkspace/crates/platform/trogon-claude-agent-sdk/tests/additional_directories.rs
The README documents the option’s language-specific names and states that paths remain ordered, are not canonicalized or deduplicated, and have no configuration-assembly restrictions. The integration test configuration includes a test that checks the empty default, path retention, order, length, and cloning.
TrogonStack/trogonai#860: Creates the SDK crate and defines the ClaudeAgentOptions field and README that this change updates.
TrogonStack/trogonai#969: Adds the Bazel macro that uses the integration_tests mapping updated here.
TrogonStack/trogonai#868: Introduces the ClaudeAgentOptions struct and README that this change extends.
Merge Risk: Minimal · previous review dd201
This adds a configuration-only option to the draft SDK with no runtime wiring, so it carries no actionable merge risk.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: it adds the additional directory option to the Claude Agent SDK. The changeset adds the public additional_directories field to ClaudeAgentOptions, documents it, and ad…
Description check
The description covers the change. It states that the new additional_directories field on ClaudeAgentOptions defaults to an empty list, stores paths without canonicalization or validation, and is docu…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: it adds the additional directory option to the Claude Agent SDK. The changeset adds the public additional_directories field to ClaudeAgentOptions, documents it, and adds a test. The title is specific and matches the primary change, so it passes.
Full details: Description check
Explanation
The description covers the change. It states that the new additional_directories field on ClaudeAgentOptions defaults to an empty list, stores paths without canonicalization or validation, and is documented in the README with a new Bazel integration test. The opening bullet is a review note, but the rest of the description matches the changeset, so the check passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit found a path to add, In a list, both long and glad. It kept each space and order true, And left the empty list there too. “Clone it once,” the rabbit cheered, “The same paths have reappeared!”
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: a0f993c1-9d1e-4fe7-9412-a36249c363d4
Commits
Reviewing files that changed from the base of the PR and between 92c44db and dd201b9.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Bazel only creates test targets for files listed in integration_tests, so unlisted tests never run in the Bazel CI job.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Additional directories are plain paths like the working directory, so leaving them out of debug output hid configuration that diagnostics need and only environment entries and model strings should stay hidden.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
A hand-written debug list silently drops every field added later. Letting the environment and model types hide their own contents keeps options debug output derived, so new settings appear without editing a list and secrets stay hidden wherever those values are printed.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Debug output now names every environment variable, which is what callers need
when diagnosing a run, while values stay redacted unless the caller marks them
plain. Making sensitive the default keeps a forgotten marker from leaking a
credential into logs.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Note
Medium Risk
Public option types change (
model,env) and new env values default to sensitive, so callers may need updates even though this remains an API draft without runtime wiring.Overview
Extends
ClaudeAgentOptionswithadditional_directories(orderedVec<PathBuf>, no canonicalization) to align with Pythonadd_dirs/ TypeScriptadditionalDirectories, with integration tests and Bazel coverage.Refactors configuration types for safer
Debugoutput:modelbecomesOption<ModelName>(model string hidden),envbecomes anEnvironmentmap ofConfigValueentries that default to sensitive unless markedPlain(names visible, secrets as<redacted>). AddsSensitiveString,ConfigValue,Environment, andModelName, exports them from the crate, and updates README and tests accordingly.Reviewed by Cursor Bugbot for commit 785bda0. Bugbot is set up for automated code reviews on this repo. Configure here.