Skip to content

feat(natsstore): bootstrap the store buckets idempotently - #8

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-probefrom
yordis/feat-natsstore-bootstrap
Open

yordis wants to merge 1 commit into
yordis/feat-natsstore-probefrom
yordis/feat-natsstore-bootstrap

Conversation

@yordis

@yordis yordis commented Nov 7, 2026 •

Copy link
Copy Markdown
Member
  • Operator-provisioned clusters must be verified rather than modified, so bucket creation is opt-in
  • Replicas start concurrently, so bootstrap is safe to race

@yordis
yordis added this pull request to stack #9 November 7, 2026 22:27
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c53f55c-d0f7-4e5a-b736-30d6e8a796fa
Commits

Reviewing files that changed from the base of the PR and between 4d21e2b and d99789d.

Files selected for processing: 4

  • internal/store/natsstore/bootstrap.go
  • internal/store/natsstore/bootstrap_test.go
  • internal/store/natsstore/buckets.go
  • internal/store/natsstore/buckets_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Operator-provisioned clusters must be verified rather than modified, and replicas start concurrently, so bucket creation is opt-in and safe to race.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-natsstore-bootstrap branch from d6d4ec3 to d99789d Compare November 7, 2026 23:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant