Skip to content

feat(natsstore): connect to NATS with the configured credentials and TLS - #6

Open
yordis wants to merge 1 commit into
yordis/feat-natsstore-settingsfrom
yordis/feat-natsstore-connect
Open

yordis wants to merge 1 commit into
yordis/feat-natsstore-settingsfrom
yordis/feat-natsstore-connect

Conversation

@yordis

@yordis yordis commented Nov 7, 2026 •

Copy link
Copy Markdown
Member
  • Auth and TLS options map one to one onto the nats CLI variables
  • Connection errors must not echo URL userinfo
  • Tests run against a real server in Docker so credential handling is exercised for real

@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 72bd81ce-07c9-47da-ba0b-20f21d7def13
Commits

Reviewing files that changed from the base of the PR and between d6e18d3 and 371be24.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 4

  • go.mod
  • internal/store/natsstore/connect.go
  • internal/store/natsstore/connect_test.go
  • internal/store/natsstore/natstest/natstest.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis added this pull request to stack #9 November 7, 2026 22:27
Auth and TLS options map one to one onto the nats CLI variables, and failures must not echo URL userinfo, so connection errors are redacted. Tests run against a real server in Docker so credential handling is exercised for real.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-natsstore-connect branch from be8d396 to 371be24 Compare November 7, 2026 23:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant