Skip to content

feat(natsstore): add NATS connection settings and bucket bootstrap - #4

Open
yordis wants to merge 1 commit into
yordis/refactor-store-backend-registryfrom
yordis/feat-natsstore-settings
Open

yordis wants to merge 1 commit into
yordis/refactor-store-backend-registryfrom
yordis/feat-natsstore-settings

Conversation

@yordis

@yordis yordis commented Nov 7, 2026 •

Copy link
Copy Markdown
Member
  • Credentials must be supplied the same way as for the other NATS tooling
  • Secrets must never reach logs or errors, so they are read into redacted types

@yordis
yordis added this pull request to stack #5 November 7, 2026 22:22
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a44a575c-1eb3-48d4-bf31-403e1a9ee534
Commits

Reviewing files that changed from the base of the PR and between 3bf5781 and d6e18d3.

Files ignored due to path filters: 1

  • go.sum is excluded by !**/*.sum
Files selected for processing: 4

  • go.mod
  • internal/store/natsstore/secret.go
  • internal/store/natsstore/settings.go
  • internal/store/natsstore/settings_test.go
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@yordis
yordis removed this pull request from stack #5 November 7, 2026 22:26
@yordis
yordis force-pushed the yordis/feat-natsstore-settings branch from bbb5c97 to 3f8f973 Compare November 7, 2026 22:27
@yordis
yordis added this pull request to stack #9 November 7, 2026 22:27
Credentials must be supplied the same way as for the other NATS tooling, and secrets must never reach logs or errors, so settings are read from the nats CLI variables into redacted types.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis
yordis force-pushed the yordis/feat-natsstore-settings branch from 3f8f973 to d6e18d3 Compare November 7, 2026 23:58

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant