Repository navigation
Conversation
Antigravity grants stay valid after use, so the journal claim is wrong for them, yet every replica refreshing the same expiring token wastes provider calls. A short lease in its own bucket lets one replica refresh while the others adopt the result. Per-key TTL is fixed at creation and an update drops it, so a lease is never renewed: it runs out on the server and the next create wins. The journal bucket stays free of TTL because its claims must never expire. Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Antigravity grants are reusable, so the no-expiry journal claim is too strict: a crashed replica would block refresh forever. A short lease in its own bucket lets one replica refresh and lets another take over after it expires. The journal bucket cannot hold key TTLs, hence the separate bucket.